refactor: move Loki TUI from --watch to --report-only - #36
Merged
Conversation
--watch with --from loki was misleading: it fetched historical data once then sat idle re-parsing the same static flows on every refresh cycle, causing a black screen on large datasets. The "watch" name implies live monitoring, which only applies to the hubble observe path. Changes: - --watch now errors when combined with --from loki, pointing users to --report-only instead - --report-only launches an interactive TUI (browse, scroll, select flows for policy generation) when stderr is a terminal; falls back to plain text output otherwise - The TUI parses flows once up front instead of re-parsing on every refresh, eliminating the blank-screen issue - Add --since/--until validation to catch inverted Loki time windows - Fix _parse_flow_list docstring that incorrectly stated flows must be pre-unwrapped (the code handles both wrapped and unwrapped)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan