Release 0.1.4 - #5
Merged
Merged
Conversation
The bug was reported against the README on the PyPI project page, and both halves of the fix travel with a release and never with a push. Measured today before cutting this, pypi.org/pypi/nodemaven/json reported provides_extras: None while the merged tree had already declared the extra - so on PyPI `pip install nodemaven[requests]` is still a warning and an install without it. Same rule 0.1.3 proved the other way round: Source and Issues sat in pyproject.toml from 0.1.1 and reached the project page only when 0.1.3 shipped, a day after the repository went public. 0.1.3.2 was considered. It is valid - PEP 440 allows a four-component release segment and it sorts between 0.1.3 and 0.1.4 - and was rejected because the third component already is the "small fix" signal and nothing reads a fourth as "smaller than a patch". 0.1.3.post1 was rejected on the spec: post-releases are for corrections that do not affect the distributed software, and this one adds an installable extra.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
__version__to0.1.4and dates the CHANGELOG entry. No other change - the content shipped in #4.Why a release at all. The bug was reported against the README on the PyPI project page, and both halves of the fix travel with a release and never with a push. Measured today, before cutting this:
So on PyPI right now
pip install nodemaven[requests]is a warning and an install withoutrequests, and the quickstart still fails. Same rule 0.1.3 proved in the other direction:SourceandIssuessat inpyproject.tomlfrom 0.1.1 and reached the project page only when 0.1.3 shipped, a day after the repository went public.On the number.
0.1.3.2was considered and is valid - PEP 440 allows a four-component release segment,packaging.Versionaccepts it, and it sorts0.1.3 < 0.1.3.post1 < 0.1.3.1 < 0.1.3.2 < 0.1.4. Rejected because the third component already is the "small fix, nothing broken" signal and no convention reads a fourth as "smaller than a patch" - an unfamiliar number spends a reader's attention on the versioning scheme instead of passing unnoticed, which is what a patch should do.0.1.3.post1was rejected on the spec rather than on taste: PEP 440 reserves post-releases for corrections that do not affect the distributed software, and this one adds an installable extra.Test plan
pytest -q- 355 passed, 3 skippedimport nodemaven; nodemaven.__version__->0.1.4ci-okv0.1.4, GitHub Release,publish.ymlthrough Trusted PublishingSummary by cubic
Releases 0.1.4 so the
requestsextra fix reaches PyPI users. The fix was already merged but only ships with a release, and PyPI currently serves 0.1.3 without the extra. This bumps__version__and dates the changelog entry.Chose 0.1.4 over 0.1.3.post1 because PEP 440 reserves post-releases for corrections that don't affect distributed software, and this adds an installable extra.
Written for commit f2b02fd. Summary will update on new commits.