Skip to content

fix(ui): ChangeHistory dropdown width collapses to its min-width - #9147

Merged
avivkeller merged 2 commits into
nodejs:mainfrom
btea:fix/changehistory-wrapper-width
Sep 8, 2026
Merged

fix(ui): ChangeHistory dropdown width collapses to its min-width#9147
avivkeller merged 2 commits into
nodejs:mainfrom
btea:fix/changehistory-wrapper-width

Conversation

@btea

@btea btea commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Description

close #9145

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@btea
btea requested a review from a team as a code owner September 7, 2026 01:50
Copilot AI lite review requested due to automatic review settings September 7, 2026 01:50
@vercel

vercel Bot commented Sep 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nodejs-org Ready Ready Preview Sep 7, 2026 2:06am UTC

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new min-w-[12rem] can override the viewport-based max-w on very narrow viewports, potentially reintroducing horizontal overflow.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adjusts the ChangeHistory dropdown panel sizing so it no longer uses a fixed width, instead sizing to its content while remaining bounded by the viewport, addressing the UI concern raised in #9145.

Changes:

  • Switches the dropdown wrapper from a fixed width (w-[26rem]) to content-based sizing (w-max).
  • Updates the max-width constraint to cap at min(26rem, 100vw - 2rem).
  • Introduces a minimum width (min-w-[12rem]) for baseline readability/consistency.
File summaries
File Description
packages/ui-components/src/Common/ChangeHistory/index.module.css Changes dropdown panel width behavior to be content-sized with viewport bounds and a minimum width.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/ui-components/src/Common/ChangeHistory/index.module.css Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: btea <2356281422@qq.com>
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.05%. Comparing base (aa05546) to head (6af766e).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9147      +/-   ##
==========================================
- Coverage   86.12%   86.05%   -0.07%     
==========================================
  Files          86       86              
  Lines        6046     6046              
  Branches      357      358       +1     
==========================================
- Hits         5207     5203       -4     
- Misses        835      839       +4     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@avivkeller
avivkeller added this pull request to the merge queue Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total First Load JS 7.06 MB
New Total First Load JS 7.06 MB
Delta 0 B (0.00%)

Merged via the queue into nodejs:main with commit 7e75c23 Sep 8, 2026
15 of 19 checks passed
@btea
btea deleted the fix/changehistory-wrapper-width branch September 9, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does the width of the changehistory item need to be adjusted?

4 participants