fix(ui): ChangeHistory dropdown width collapses to its min-width - #9147
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
🟡 Changes recommended
The new min-w-[12rem] can override the viewport-based max-w on very narrow viewports, potentially reintroducing horizontal overflow.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adjusts the ChangeHistory dropdown panel sizing so it no longer uses a fixed width, instead sizing to its content while remaining bounded by the viewport, addressing the UI concern raised in #9145.
Changes:
- Switches the dropdown wrapper from a fixed width (
w-[26rem]) to content-based sizing (w-max). - Updates the max-width constraint to cap at
min(26rem, 100vw - 2rem). - Introduces a minimum width (
min-w-[12rem]) for baseline readability/consistency.
File summaries
| File | Description |
|---|---|
| packages/ui-components/src/Common/ChangeHistory/index.module.css | Changes dropdown panel width behavior to be content-sized with viewport bounds and a minimum width. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: btea <2356281422@qq.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9147 +/- ##
==========================================
- Coverage 86.12% 86.05% -0.07%
==========================================
Files 86 86
Lines 6046 6046
Branches 357 358 +1
==========================================
- Hits 5207 5203 -4
- Misses 835 839 +4
Partials 4 4 ☔ View full report in Codecov by Harness. |
📦 Build Size ComparisonSummary
|
Description
close #9145
Validation
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.