Skip to content

doc: document invalid X509Certificate validity times #67406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SarthakAhuja wants to merge 3 commits into
base: main
Choose a base branch
from
+26 −0
Open

doc: document invalid X509Certificate validity times #67406

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0baec30
doc: document invalid X509Certificate validity times
SarthakAhuja Nov 11, 2026
02ed95d
doc: recommend in-window X509Certificate validity check
SarthakAhuja Nov 11, 2026
33ca48a
doc: use reviewer wording for X509Certificate dates
SarthakAhuja Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions doc/api/crypto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3517,6 +3517,9 @@ added: v15.6.0

The date/time from which this certificate is valid.

If the certificate's `notBefore` time cannot be parsed, this is the string
`'Bad time value'`.

### `x509.validFromDate`

<!-- YAML
Expand All @@ -3529,6 +3532,16 @@ added:

The date/time from which this certificate is valid, encapsulated in a `Date` object.

If the certificate's `notBefore` time cannot be parsed, this property is an
invalid `Date` whose `getTime()` method returns `NaN`.

Relational comparisons with an invalid `Date` evaluate to `false`. To check
whether the current time is within the certificate's validity period, use
`now >= x509.validFromDate && now <= x509.validToDate`. This expression
evaluates to `false` if either date is invalid. Checking
`now < x509.validFromDate || now > x509.validToDate` instead can fail to
reject certificates with invalid dates.

### `x509.validTo`

<!-- YAML
Expand All @@ -3539,6 +3552,9 @@ added: v15.6.0

The date/time until which this certificate is valid.

If the certificate's `notAfter` time cannot be parsed, this is the string
`'Bad time value'`.

### `x509.validToDate`

<!-- YAML
Expand All @@ -3551,6 +3567,16 @@ added:

The date/time until which this certificate is valid, encapsulated in a `Date` object.

If the certificate's `notAfter` time cannot be parsed, this property is an
invalid `Date` whose `getTime()` method returns `NaN`.

Relational comparisons with an invalid `Date` evaluate to `false`. To check
whether the current time is within the certificate's validity period, use
`now >= x509.validFromDate && now <= x509.validToDate`. This expression
evaluates to `false` if either date is invalid. Checking
`now < x509.validFromDate || now > x509.validToDate` instead can fail to
reject certificates with invalid dates.

### `x509.signature`

<!-- YAML
Expand Down
Loading