Skip to content

test: increase iterations on histogram test after snapshot changes - #67379

Open
sxa wants to merge 1 commit into
nodejs:mainfrom
sxa:increase_histogram_iterations
Open

sxa wants to merge 1 commit into
nodejs:mainfrom
sxa:increase_histogram_iterations

Conversation

@sxa

@sxa sxa commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Fixes #67374

Some analysis from IBM Bob indicated that the preload streams into startup snapshot PR could have changed the memory allocation in a way that no longer triggers GC events when the test expects them too on Linux/ppc64le. Some tests done locally on one of the machines show that increasing the number of iterations is sufficient for the test to pass consistently as expected after the change on one of the RHEL10 machines, but I will also verify it with a stress test run on the machine that has most frequently seen the error.

Adding Matteo as a review as the author of the preload streams PR and James as original author of the test.

Alternative solution: Make this value specific to Linux/ppc64le since it does not appear to affect other platforms, but the contents of this PR is a simpler change.

We could consider fast tracking this as it has been impacting PR testing and is not a change that affects runtime functionality.

Signed-off-by: Stewart X Addison <sxa@ibm.com>
@sxa
sxa requested review from jasnell and mcollina November 10, 2026 14:31
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 10, 2026
@sxa

sxa commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

Confirmed that https://ci.nodejs.org/job/node-stress-single-test/979/ has demonstrated 1000/1000 passes of the test with this PR on both test-osuosl-rhel10-ppc64_le-1 and test-osuosl-rhel8-ppc64_le-4.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.72%. Comparing base (2929073) to head (1abcd39).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67379      +/-   ##
==========================================
- Coverage   92.62%   90.72%   -1.90%     
==========================================
  Files         430      798     +368     
  Lines      196333   280074   +83741     
  Branches    29897    53880   +23983     
==========================================
+ Hits       181849   254099   +72250     
- Misses      14159    16276    +2117     
- Partials      325     9699    +9374     

see 510 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@sxa

sxa commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

Noting that this is not exclusive to plinux - it has also been seen as a failure on zlinux: https://ci.nodejs.org/job/node-test-commit-linuxone/59810/nodes=rhel8-s390x/

@pipobscure pipobscure left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test-perf-hooks-histogram-external-memory failures on node-test-comit-plinux

3 participants