Repository navigation
Conversation
Avoid the cost of primordial push calls for each formatted entry. Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67295 +/- ##
==========================================
- Coverage 93.00% 90.67% -2.33%
==========================================
Files 428 797 +369
Lines 195754 279605 +83851
Branches 30290 53789 +23499
==========================================
+ Hits 182054 253532 +71478
- Misses 13374 16353 +2979
- Partials 326 9720 +9394
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid the cost of primordial push calls for each formatted entry by using indexed writes to collect formatted
SetandMapentries. Similar approach as for this PR: #66872In local 30-sample benchmarks, inspecting 50-element collections improved
throughput by 15.9% for Sets and 8.7% for Maps. Reverse comparisons
confirmed both gains, with no corrected-significant regressions in the
broader comparison.