[LiviaMedeiros]

In v27.x we can sum numbers natively.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.71%. Comparing base (96de0e2) to head (525314b).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #67222      +/-   ##
==========================================
- Coverage   92.99%   90.71%   -2.29%     
==========================================
  Files         428      797     +369     
  Lines      195633   278888   +83255     
  Branches    30268    53633   +23365     
==========================================
+ Hits       181937   252986   +71049     
- Misses      13369    16266    +2897     
- Partials      327     9636    +9309     

Files with missing lines	Coverage Δ
lib/internal/bench_runner/benchmark.js	99.65% <100.00%> (-0.01%)	⬇️

... and 500 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78820/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78855/

[nodejs-github-bot]

Commit Queue failed

This pull request has multiple commits, but no landing policy was selected.

Add commit-queue-squash PRs the Commit Queue should land as one squashed commit. to land it as one commit, or commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. to land the commits separately.

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output

�[36m⠋�[39m Loading data for nodejs/node/pull/67222
�[36m⠋�[39m Loading data for nodejs/node/pull/67222
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/67222
�[36m⠋�[39m Getting reviews from nodejs/node/pull/67222
�[36m⠋�[39m Getting comments from nodejs/node/pull/67222
�[36m⠋�[39m Getting commits from nodejs/node/pull/67222
✔  Done loading data for nodejs/node/pull/67222
----------------------------------- PR info ------------------------------------
Title      bench_runner: replace Kahan summation with `MathSumPrecise` (#67222)
Author     Livia Medeiros <livia@cirno.name> (@LiviaMedeiros)
Branch     LiviaMedeiros:bench-kahan-sumprecise -> nodejs:main
Labels     lib / src, author ready, needs-ci, commit-queue, dont-land-on-v22.x, dont-land-on-v24.x, dont-land-on-v26.x
Commits    3
 - lib: replace Kahan summation with `MathSumPrecise`
 - Update lib/internal/bench_runner/benchmark.js
 - squash: import `SafeArrayIterator`
Committers 2
 - LiviaMedeiros <livia@cirno.name>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/67222
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/67222
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 03 Nov 2026 10:48:32 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/67222#pullrequestreview-5759984386
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/67222#pullrequestreview-5788490888
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-11-05T08:10:12Z: https://ci.nodejs.org/job/node-test-pull-request/78855/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78855/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78855/
�[36m⠙�[39m Querying API for job/node-test-pull-request/78855/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
�[36m⠹�[39m Bringing origin/main up to date...
�[36m⠹�[39m Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
�[36m⠸�[39m Downloading patch for 67222
�[36m⠸�[39m Downloading patch for 67222
From https://github.com/nodejs/node
 * branch                  refs/pull/67222/merge -> FETCH_HEAD
✔  Fetched commits as 8337f973de8e..525314bf5add
--------------------------------------------------------------------------------
[main 4fa8886613] lib: replace Kahan summation with `MathSumPrecise`
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Tue Nov 3 18:26:09 2026 +0800
 1 file changed, 2 insertions(+), 13 deletions(-)
[main 98770afe79] Update lib/internal/bench_runner/benchmark.js
 Author: Livia Medeiros <livia@cirno.name>
 Date: Tue Nov 3 23:51:23 2026 +0800
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 216020cf45] squash: import `SafeArrayIterator`
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Tue Nov 3 23:56:27 2026 +0800
 1 file changed, 1 insertion(+)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
(node:390) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
lib: replace Kahan summation with `MathSumPrecise`

Signed-off-by: LiviaMedeiros <livia@cirno.name>
PR-URL: https://github.com/nodejs/node/pull/67222
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 1e9c2d00a6] lib: replace Kahan summation with `MathSumPrecise`
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Tue Nov 3 18:26:09 2026 +0800
 1 file changed, 2 insertions(+), 13 deletions(-)
Rebasing (3/6)
Rebasing (4/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update lib/internal/bench_runner/benchmark.js

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/67222
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 962e877594] Update lib/internal/bench_runner/benchmark.js
 Author: Livia Medeiros <livia@cirno.name>
 Date: Tue Nov 3 23:51:23 2026 +0800
 1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (5/6)
Rebasing (6/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
squash: import `SafeArrayIterator`

Signed-off-by: LiviaMedeiros <livia@cirno.name>
PR-URL: https://github.com/nodejs/node/pull/67222
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 3922575343] squash: import `SafeArrayIterator`
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Tue Nov 3 23:56:27 2026 +0800
 1 file changed, 1 insertion(+)
Successfully rebased and updated refs/heads/main.
--------------------------------------------------------------------------------
   ℹ  Add `commit-queue-squash` label to land the PR as one commit, or `commit-queue-rebase` to land as separate commits.

View workflow run

[nodejs-github-bot]

Landed in 708f09c