Skip to content

test: converting for each to for..of - #67126

Open
SergioCalderon101 wants to merge 1 commit into
nodejs:mainfrom
SergioCalderon101:test-resource-usage-for-of
Open

SergioCalderon101 wants to merge 1 commit into
nodejs:mainfrom
SergioCalderon101:test-resource-usage-for-of

Conversation

@SergioCalderon101

Copy link
Copy Markdown

Replaced forEach with for...of in test-resource-usage.js, my second practice and contribution to Node.js!

Signed-off-by: Sergio Calderon <sergioo.calderonn@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 29, 2026
@Ethan-Arrowood Ethan-Arrowood added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 29, 2026

@Ethan-Arrowood Ethan-Arrowood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀🐢🌮

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.67%. Comparing base (ee982db) to head (d369059).
⚠️ Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67126      +/-   ##
==========================================
- Coverage   90.67%   90.67%   -0.01%     
==========================================
  Files         797      797              
  Lines      278791   278791              
  Branches    53616    53611       -5     
==========================================
- Hits       252807   252789      -18     
- Misses      16334    16373      +39     
+ Partials     9650     9629      -21     

see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ethan-Arrowood Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 30, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 30, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@Ethan-Arrowood Ethan-Arrowood added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 2, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 2, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

✖ GitHub CI is still running

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
�[36m⠋�[39m Loading data for nodejs/node/pull/67126
�[36m⠋�[39m Loading data for nodejs/node/pull/67126
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/67126
�[36m⠋�[39m Getting reviews from nodejs/node/pull/67126
�[36m⠋�[39m Getting comments from nodejs/node/pull/67126
�[36m⠋�[39m Getting commits from nodejs/node/pull/67126
✔  Done loading data for nodejs/node/pull/67126
----------------------------------- PR info ------------------------------------
Title      test: converting for each to for..of (#67126)
Author     Sergio Calderon <sergioo.calderonn@gmail.com> (@SergioCalderon101, first-time contributor)
Branch     SergioCalderon101:test-resource-usage-for-of -> nodejs:main
Labels     test, code-and-learn, needs-ci, commit-queue
Commits    1
 - test: converting for each to for..of
Committers 1
 - Sergio Calderon <sergioo.calderonn@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/67126
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/67126
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 29 Oct 2026 22:33:44 GMT
   ✔  Approvals: 2
   ✔  - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/67126#pullrequestreview-5705925288
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/67126#pullrequestreview-5739411660
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2026-10-30T06:26:52Z: https://ci.nodejs.org/job/node-test-pull-request/78728/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78728/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78728/
�[36m⠙�[39m Querying API for job/node-test-pull-request/78728/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants