Skip to content

stream: second batch of stream/iter fixes - #65658

Open
jasnell wants to merge 22 commits into
nodejs:mainfrom
jasnell:jasnell/stream-iter-fixes-2
Open

stream: second batch of stream/iter fixes#65658
jasnell wants to merge 22 commits into
nodejs:mainfrom
jasnell:jasnell/stream-iter-fixes-2

Conversation

@jasnell

@jasnell jasnell commented Aug 30, 2026

Copy link
Copy Markdown
Member

Builds off #65652 .. will remain draft util that batch lands and this can be rebased... The first 10 commits are from the other PR

jasnell added 22 commits August 29, 2026 23:19
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@jasnell
jasnell requested a review from trivikr August 30, 2026 04:36
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic
  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Aug 30, 2026
@codecov

codecov Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.94231% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.05%. Comparing base (045ff95) to head (ac2cfb4).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/streams/iter/push.js 85.27% 15 Missing and 4 partials ⚠️
lib/internal/streams/iter/pull.js 92.24% 17 Missing and 1 partial ⚠️
lib/internal/streams/iter/broadcast.js 86.95% 11 Missing and 1 partial ⚠️
lib/internal/streams/iter/share.js 93.40% 6 Missing ⚠️
lib/internal/streams/iter/consumers.js 96.58% 4 Missing ⚠️
lib/internal/streams/iter/from.js 84.61% 2 Missing ⚠️
lib/internal/fs/promises.js 94.11% 1 Missing ⚠️
lib/internal/streams/iter/duplex.js 97.56% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65658      +/-   ##
==========================================
- Coverage   91.79%   90.05%   -1.74%     
==========================================
  Files         402      755     +353     
  Lines      181164   256120   +74956     
  Branches    27776    48349   +20573     
==========================================
+ Hits       166308   230661   +64353     
- Misses      14517    16595    +2078     
- Partials      339     8864    +8525     
Files with missing lines Coverage Δ
lib/internal/quic/quic.js 100.00% <100.00%> (ø)
lib/internal/streams/iter/classic.js 89.22% <100.00%> (-0.07%) ⬇️
lib/internal/streams/iter/utils.js 98.44% <100.00%> (+0.20%) ⬆️
lib/internal/streams/iter/webidl.js 100.00% <100.00%> (ø)
lib/internal/fs/promises.js 92.24% <94.11%> (+2.00%) ⬆️
lib/internal/streams/iter/duplex.js 97.08% <97.56%> (+0.73%) ⬆️
lib/internal/streams/iter/from.js 88.83% <84.61%> (+0.49%) ⬆️
lib/internal/streams/iter/consumers.js 95.63% <96.58%> (-1.01%) ⬇️
lib/internal/streams/iter/share.js 87.45% <93.40%> (+1.04%) ⬆️
lib/internal/streams/iter/broadcast.js 89.49% <86.95%> (+1.05%) ⬆️
... and 2 more

... and 485 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants