Repository navigation
src: report why --enable-fips failed - #64979
Merged
Merged
Conversation
The startup failure always appended the OpenSSL error queue, so when Node.js itself detected the missing fips provider it printed an error header followed by nothing. Report the reason instead. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
approved these changes
Aug 3, 2026
panva
added
author ready
richardlau
reviewed
Aug 3, 2026
| const FIPS_ENABLE_ERROR_STRING = 'OpenSSL error when trying to enable FIPS:'; | ||
| const FIPS_ENABLE_ERROR_STRING = | ||
| hasOpenSSL3 ? | ||
| '--enable-fips requires an active OpenSSL provider named "fips"' : |
Member
There was a problem hiding this comment.
Was something changed recently in Node.js that forced this? My recollection was that there is no restriction in OpenSSL 3 (the providers can be called anything (you could even have a provider called "fips" that doesn't support FIPS)) and Node.js didn't enforce that restriction either.
Member
Author
There was a problem hiding this comment.
I traced it back to 1997aa3, so not recently. You're right that OpenSSL itself only cares about the fips=yes default property and maybe we can fix all in one swoop. 👀
Member
Author
There was a problem hiding this comment.
In other words, yes this is the correct message to give as-is unless we change ProcessFipsOptions
panva
removed
request-ci
richardlau
approved these changes
Aug 3, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64979 +/- ##
==========================================
- Coverage 90.28% 90.27% -0.01%
==========================================
Files 762 762
Lines 247524 247534 +10
Branches 46684 46693 +9
==========================================
+ Hits 223466 223470 +4
- Misses 15490 15506 +16
+ Partials 8568 8558 -10
🚀 New features to boost your workflow:
|
aduh95
approved these changes
Aug 3, 2026
Collaborator
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in b79dcdf |
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
The startup failure always appended the OpenSSL error queue, so when Node.js itself detected the missing fips provider it printed an error header followed by nothing. Report the reason instead. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64979 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
The startup failure always appended the OpenSSL error queue, so when Node.js itself detected the missing fips provider it printed an error header followed by nothing. Report the reason instead. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64979 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 27, 2026
The startup failure always appended the OpenSSL error queue, so when Node.js itself detected the missing fips provider it printed an error header followed by nothing. Report the reason instead. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64979 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The startup failure always appended the OpenSSL error queue, so when Node.js itself detected the missing fips provider it printed an error header followed by nothing. Report the reason instead.