build: add QUIC CI job for PRs matching QUIC related paths#63875
Conversation
|
Review requested:
|
nodejs-github-bot
added
the
meta
|
CC @nodejs/quic |
|
At what point do we intend to take quic out from behind the build flag? |
Hard to say, but at the moment there's still quite a few very breaking API changes to come that are already visible, along with plenty of other work to do on the details. I'd lean towards keeping it behind the build flag for a bit longer, until that settles down somewhat. Obviously it doesn't need to be perfectly stable for an experimental runtime flag, but it's a bit inconvenient if the API breaks every other release. |
This notable includes stream/iter (since they're closely related and rapidly evolving together) and ngtcp2, nghttp3 & openssl deps. Based on test-linux.yml, the main differences are simplifications: PRs only, filtered to specific paths, just one build (ARM only), no unusual characters test. Signed-off-by: Tim Perry <pimterry@gmail.com>
bjohansebas
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/63875 ✔ Done loading data for nodejs/node/pull/63875 ----------------------------------- PR info ------------------------------------ Title build: add QUIC CI job for PRs matching QUIC related paths (#63875) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch pimterry:quic-ci-job -> nodejs:main Labels meta, author ready Commits 1 - build: add QUIC CI job for PRs matching QUIC related paths Committers 1 - Tim Perry <pimterry@gmail.com> PR-URL: https://github.com/nodejs/node/pull/63875 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63875 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 12 Jun 2026 11:24:54 GMT ✔ Approvals: 1 ✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/63875#pullrequestreview-4491276090 ✘ This PR needs to wait 115 more hours to land (or 0 minutes if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/27506119139 |
bjohansebas
removed
the
commit-queue-failed
pimterry
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2315bd3 |
|
I'm a bit late to the party, but FYI there was some concern raised in #61446 (comment) last time I suggested something like this. If the idea is that it's valid to disable the QUIC action when it ever starts failing, we should be fine. |
This notable includes stream/iter (since they're closely related and rapidly evolving together) and ngtcp2, nghttp3 & openssl deps. Based on test-linux.yml, the main differences are simplifications: PRs only, filtered to specific paths, just one build (ARM only), no unusual characters test. Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: #63875 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@aduh95 I think that's fair. Yes, if this starts failing due to issues elsewhere we should disable it, and I agree with @targos's comment there that really this should be true for any experimental build flag. We could make it a general policy if that'd be useful. It is important to know when this breaks, but it should never block releases or non-QUIC dev - it should block changes to the specific areas listed (stream/iter + QUIC + related deps) but if a failure blocks unrelated otherwise correct PRs or if it breaks on main, disabling it and pinging nodejs/quic to investigate is the right move. |
7 participants
Matching paths notably includes stream/iter (since they're closely related and rapidly evolving together) and ngtcp2, nghttp3 & openssl deps.
The config here is based primarily on test-linux.yml, the diffs are simplifications: PRs only to limit the disruption (don't run on branches & releases etc for now), filtered to specific paths, just one build (ARM only, like test-internet/test-shared), no unusual characters test.
This will fail until #63874 & #63821 are merged - that's expected, QUIC builds are currently broken on main.PRs now merged, this has been rebased and it's all passing 🥳I'm hoping all the tiny fixes there will go in pretty fast though, happy to discuss the CI job here separately and check the best setup approach for this while QUIC is still experimental. This is my first time touching any of Node CI so let me know if this isn't quite right somewhere.