meta: add support for alpha prerelease tag#63135
Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Review requested:
|
|
So, under this schema, alpha versions would be named |
Why? What would be the upside? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63135 +/- ##
==========================================
+ Coverage 89.67% 89.70% +0.02%
==========================================
Files 712 712
Lines 221251 221251
Branches 42393 42390 -3
==========================================
+ Hits 198413 198464 +51
+ Misses 14681 14622 -59
- Partials 8157 8165 +8 🚀 New features to boost your workflow:
|
| #define NODE_ALPHA_MAJOR_VERSION a | ||
| #define NODE_ALPHA_MINOR_VERSION b | ||
| #define NODE_ALPHA_PATCH_VERSION c |
There was a problem hiding this comment.
I wouldn't include MINOR or PATCH for Alpha. Possibly, we should only have:
#define NODE_IS_ALPHA_RELEASE 0
#define NODE_ALPHA_MAJOR_VERSION 0and increment NODE_ALPHA_MAJOR_VERSION on every release until LTS.
There was a problem hiding this comment.
Why? What would be the upside?
There was a problem hiding this comment.
It's simpler. We won't need to maintain a guarantee that v27.0.0-alpha.2 won't break v27.0.0-alpha.1 users, as it would need to be guaranteed if we decide to ship v27.0.0-alpha.1.1.0 on top of v27.0.0-alpha.1.0.0
There was a problem hiding this comment.
Note that starting simpler would allow us to go to your suggested model if we feel the need. The opposite is not true.
There was a problem hiding this comment.
The opposite is not true.
I don't think so, either we need to pick a system and stick to it, either we can change if we feel the need. I don't see why we could go from -alpha.1 to -alpha.1.0.1 and not from -alpha.1.0.1 to -alpha.2
There was a problem hiding this comment.
If we seek to provide semver semantics within the alpha phase, then we've just re-invented the old release model IMO. May need discussion, but I think it makes more sense to have the alpha versioning be linear, with no undertaking to provide any non-breakage guarantees between any two alpha builds. (I imagine that would make things significantly more straightforward for releasers as well!)
Refs: nodejs/Release#1154
There would be more work needed on the tooling (i.e. NCU), but let's see first if we have consensus on the process.