test: make transformProjectRoot CWD-agnostic #61506
Open
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Fix issue where tests fail when run from directories like /node because the project root path appears as a substring in URLs (nodejs.org) or other paths (/node_modules). Use a regex that only matches the project root when followed by a path separator, colon, whitespace, or end of string. Fixes: nodejs#61303
Jimmynycu
force-pushed
the
fix/cwd-agnostic-tests
branch
from
3d11152 to
067cbdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where tests fail when run from directories like /node because the project root path appears as a substring in URLs (nodejs.org) or other paths (/node_modules).
Use a regex that only matches the project root when followed by a path separator, colon, whitespace, or end of string.
Fixes: #61303