Skip to content

fix: pinned windows over fullscreen window while dragging - #7

Open
Yocraft-2000 wants to merge 2 commits into
noctalia-dev:mainfrom
Yocraft-2000:fix-pinned-windows
Open

fix: pinned windows over fullscreen window while dragging#7
Yocraft-2000 wants to merge 2 commits into
noctalia-dev:mainfrom
Yocraft-2000:fix-pinned-windows

Conversation

@Yocraft-2000

Copy link
Copy Markdown
Contributor

Summary

Pinned windows stays over fullscreen windows while moving them.

Motivation

The pinned windows disappeared when moving them over a fullscreen window.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Build / packaging
  • Documentation

Related Issue

On discord.

Testing

Manual Coverage

  • Tested in a nested Umbriel session
  • Tested in a native Umbriel session
  • Tested with multiple monitors
  • Tested with a scaled output
  • Tested with native Wayland applications
  • Tested with X11 applications through xwayland-satellite
  • Tested with the scrolling layout
  • Tested with the dwindle layout

Screenshots / Videos

Checklist

  • This PR is ready for review, or it is marked as Draft.
  • I read and followed the relevant guidance in CONTRIBUTING.md.
  • I initialized and updated the SceneFX submodule where required.
  • I ran just format, or this PR has no C++ changes.
  • I ran the relevant build, test, lint, or verification commands, or explained why they were not run.
  • I functionally verified compositor behavior where automated checks are insufficient.
  • I self-reviewed the changes.
  • I checked for new warnings or errors.
  • I updated docs/ and examples/config.toml, or this PR does not change user-facing configuration or behavior.
  • I used canonical names for config keys, IPC actions, paths, and identifiers.

Additional Notes

@Ly-sec

Ly-sec commented Aug 23, 2026

Copy link
Copy Markdown
Member

Hey @Yocraft-2000 the fix looks reasonable, but the reset changes dragTree ordering relative to dragIconTree, which could place dragged windows above data-device drag icons.

Could you restore the original order by placing dragTree below dragIconTree, then dragShadowTree below dragTree? That would also make the newly added layer-shell protocol include unnecessary in view.cpp I'm fairly certain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants