Skip to content

fix(cider): seek-aware lyrics stack and ghost-idle cleanup - #454

Open
dragged9698 wants to merge 1 commit into
noctalia-dev:mainfrom
dragged9698:fix/cider-1.9.2-lyrics-seek
Open

fix(cider): seek-aware lyrics stack and ghost-idle cleanup#454
dragged9698 wants to merge 1 commit into
noctalia-dev:mainfrom
dragged9698:fix/cider-1.9.2-lyrics-seek

Conversation

@dragged9698

Copy link
Copy Markdown
Contributor

Plugin

  • Id: dragged/cider
  • New plugin
  • Update to an existing plugin (version bumped in plugin.toml)

What it does

Bump dragged/cider from 1.8.4 → 1.9.2 (plugin_api 23 → 24 for argv-table noctalia.runAsync).

User-visible fixes:

  • Seeking lyrics: scrubbing / skipping forward or back now drives the karaoke stack the matching way (promote vs reverse), with softer mid-seek interrupts so direction stays consistent instead of flipping after the clock settles.
  • Ghost now-playing: quitting Cider (or losing the window) clears sidecars and hides the bar chip / notifications that used to linger from stale state.json.
  • Lyrics clock: trusted Cider time/track events re-anchor immediately; untrusted poll spikes no longer leave the HUD stuck ahead.

External dependencies

Unchanged from the published plugin. Declared in plugin.toml:

  • python3 — runs scripts/cider_bridge.py and scripts/lyrics_overlay.py
  • gtk3 / gtk-layer-shell / python-gobject — lyrics overlay (PyGObject + cairo)

Pip packages (see cider/requirements.txt): python-socketio, requests, websocket-client.

Also spawned (not extra manifest names): bash (scripts/start-bridge.sh), pkill (bridge replace / disable), python3.

Testing

  • Local python3 -m unittest discover -s cider/scripts -p 'test_*.py' (58 tests)

  • python3 .github/workflows/scripts/validate-plugins.py (109 manifests OK)

  • noctalia plugins lint cider (0 errors, 0 warnings)

  • Manual seek forward/back on the lyrics HUD and Cider quit → idle bar hide on Niri

  • Tested on Niri

  • Tested on Hyprland

  • Tested on Sway

  • Tested on another compositor:

  • Noctalia version tested against: v5.0.0-beta.9+

  • Plugin API level: 24

Screenshots / Videos

Lyrics HUD / seek behavior is runtime-only; store card unchanged:

Cider store thumbnail

Checklist

Ready-for-review requirement: Every box in this section must be checked. If any statement is not true, keep the
pull request as Draft. An explanation does not replace a required check.

  • The directory name matches the part of id after the / in plugin.toml exactly.
  • It ships plugin.toml, README.md, thumbnail.webp, and translations/en.json.
  • README.md follows the
    README template, documents
    every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
  • I created thumbnail.webp with the thumbnail generator.
  • version follows semver and is bumped in this PR; plugin_api is the oldest API level this plugin requires.
  • Every non-English translation in this PR uses a locale supported by Noctalia core, and I can read, write, and
    understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
  • I did not edit catalog.toml; CI generates it.
  • This PR touches exactly one plugin directory.

Code review attestation

Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
Ready-for-review requirement: Every attestation below must be checked.

  • The code is readable and not obfuscated, minified, or generated.
  • It does not download and execute remote code.
  • Every network call, filesystem write, and spawned process is something the description above accounts for.
  • I have the right to publish this code under the license declared in plugin.toml.

Network, filesystem, processes

  • Network: Cider Connectivity HTTP/Socket.IO on base_url (default http://127.0.0.1:10767) via the tokened Session. Lyrics via Cider amapi/run-v3; LRCLIB fallback and Apple Music CDN artwork via bare requests.get (no Cider token headers).
  • Filesystem writes: ~/.cache/noctalia-cider/ (state, lyrics, artwork, HUD, apptoken file), noctalia.pluginDataDir() durable settings, /tmp/noctalia-cider-bridge.log, /tmp/noctalia-cider-lyrics-overlay.log. No writes into pluginDir().
  • Processes: bash scripts/start-bridge.shpython3 scripts/cider_bridge.py; python3 scripts/lyrics_overlay.py; pkill of the bridge on replace/disable; overlay stop via pidfile.

Bump 1.8.4 → 1.9.2. Bidirectional lyric transitions follow seek direction,
position clock re-anchors on trusted seeks, and quitting Cider clears ghost
now-playing / idle bar state. Raises plugin_api to 24 for argv runAsync.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant