fix: wrap non-JSON responses in EnableBankingException#6
Merged
Conversation
_request only wrapped HTTP errors (raise_for_status) into EnableBankingException. A successful status code with a non-JSON body (e.g. an empty 200 response) made response.json() raise requests' JSONDecodeError, which leaked to callers instead of being handled like any other request failure. Catch it and wrap it, attaching the response so callers can still inspect the status code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_requestonly wrapped HTTP errors (raise_for_status) intoEnableBankingException200) makesresponse.json()raise a rawrequests.exceptions.JSONDecodeError, which leaks past consumers that only catchEnableBankingExceptionEnableBankingException, keeping theresponseattached so callers can still inspect the status code_request's error handling was previously untested)