Skip to content

Fix open issues; bump to 1.2.0 - #172

Merged
noahweidig merged 3 commits into
mainfrom
test/practical-ride-nv80b0
Nov 11, 2026
Merged

noahweidig merged 3 commits into
mainfrom
test/practical-ride-nv80b0

Conversation

@noahweidig

@noahweidig noahweidig commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Version 1.2.0. See NEWS.md.

  • get_sefire() returns only existing ZIP paths after failed downloads
  • get_wui()/get_nifc()/get_fod() re-unzip when extracted files are missing (new .unzip_if_needed() helper)
  • Large-download warnings state real sizes (sefire 1-3 GB, MTBS 360 MB, FOD 175 MB, NIFC 49 MB)
  • Docs: get_sefire "silently ignored", read_nifc .gdb, NIFC size, README
  • Removed tracked session artifacts; added to .gitignore
  • Tests: sefire warning regression, partial-failure return, WUI re-unzip, sefire integration, FOD archive guard
  • testthat >= 3.2.0 (mocking)

Not run locally (no R in this environment); relies on CI.

Fixes #168, #167, #166, #165, #164, #163, #162, #160, #156, #153, #152

🤖 Generated with Claude Code

https://claude.ai/code/session_015S8yjXxoFgRtvDUoqf4ZSP

get_sefire() returns only existing paths (#166); re-unzip when extracted
files are missing (#164); size-accurate large-download warnings and NIFC
size docs (#160, #165, #162); add tests (#167, #163, #152); update NEWS
and docs.
@noahweidig noahweidig changed the title docs: fix stale get_sefire/read_nifc docs; remove session artifacts Fix open issues; bump to 1.2.0 Nov 11, 2026
@noahweidig
noahweidig marked this pull request as ready for review November 11, 2026 14:14
@noahweidig
noahweidig merged commit f72655a into main Nov 11, 2026
2 of 6 checks passed
@noahweidig
noahweidig deleted the test/practical-ride-nv80b0 branch November 11, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_sefire() @section About SE FireMap says years is "silently ignored" but code emits a warning

2 participants