Skip to content

Rules: prefetched post-type field list (ACF + registered + DB) #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmbrthirteen merged 1 commit into from
Jun 30, 2026
Merged

Rules: prefetched post-type field list (ACF + registered + DB) #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 35 additions & 9 deletions src/Admin/RestController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,18 +161,44 @@ public function post_type_fields( WP_REST_Request $request ): WP_REST_Response {
return new WP_REST_Response( [ 'ok' => true, 'fields' => [] ], 200 );
}

$keys = (array) $wpdb->get_col(
$wpdb->prepare(
"SELECT DISTINCT pm.meta_key FROM {$wpdb->postmeta} pm
INNER JOIN {$wpdb->posts} p ON p.ID = pm.post_id
WHERE p.post_type = %s AND pm.meta_key NOT LIKE %s
ORDER BY pm.meta_key LIMIT 200",
$type,
$wpdb->esc_like( '_' ) . '%'
$keys = [ 'post_title', 'post_date' ];

$keys = array_merge(
$keys,
(array) $wpdb->get_col(
$wpdb->prepare(
"SELECT DISTINCT pm.meta_key FROM {$wpdb->postmeta} pm
INNER JOIN {$wpdb->posts} p ON p.ID = pm.post_id
WHERE p.post_type = %s AND pm.meta_key NOT LIKE %s
ORDER BY pm.meta_key LIMIT 300",
$type,
$wpdb->esc_like( '_' ) . '%'
)
)
);

return new WP_REST_Response( [ 'ok' => true, 'fields' => array_values( array_map( 'strval', $keys ) ) ], 200 );
// ACF field names for this post type (the values live under the field name as meta).
if ( function_exists( 'acf_get_field_groups' ) && function_exists( 'acf_get_fields' ) ) {
foreach ( (array) acf_get_field_groups( [ 'post_type' => $type ] ) as $group ) {
foreach ( (array) acf_get_fields( $group['key'] ?? '' ) as $field ) {
if ( ! empty( $field['name'] ) ) {
$keys[] = (string) $field['name'];
}
}
}
}

// Meta registered via register_post_meta().
foreach ( array_keys( get_registered_meta_keys( 'post', $type ) ) as $registered ) {
if ( strpos( (string) $registered, '_' ) !== 0 ) {
$keys[] = (string) $registered;
}
}

$keys = array_values( array_unique( array_filter( array_map( 'strval', $keys ) ) ) );
sort( $keys );

return new WP_REST_Response( [ 'ok' => true, 'fields' => $keys ], 200 );
}

public function scrape_preview( WP_REST_Request $request ): WP_REST_Response {
Expand Down
Loading