fix(rust): pin mt-core/llm-cascade git deps — owner build was broken - #27
Closed
vitaliytv wants to merge 1 commit into
Closed
fix(rust): pin mt-core/llm-cascade git deps — owner build was broken#27vitaliytv wants to merge 1 commit into
vitaliytv wants to merge 1 commit into
Conversation
Both `mt-core` (app/src-tauri, owner/src-tauri) and `llm-cascade` (owner/owner-llm) depended on unpinned git sources. Both upstream repos were restructured since: - nitra/mt split into a spec-only repo (nitra/mt) plus an implementation repo (nitra/mt-rust) — mt-core moved to the latter. HEAD of nitra/mt no longer has any Cargo.toml at all, so any fresh git fetch that didn't hit Cargo.lock's pinned SHA resolved straight to a broken checkout: `could not find Cargo.toml in .../checkouts/...`. - llm-cascade was renamed to llm-lib inside nitra/7n-rules (crate moved from llm-lib/crates/llm-cascade to llm-lib/crates/llm-lib). This has been silently breaking owner's DMG build in CI for a while — every recent release-owner.yml run failed at this exact step, and no owner release since owner-v0.15.0 has shipped a working artifact. Fix: point both git deps at their new homes with an explicit `rev` (matching the existing tauri-plugin-agent convention in app/src-tauri/Cargo.toml), so resolution no longer depends on what happens to be at the remote's default-branch HEAD. owner-llm keeps consuming the renamed crate under its old local name via Cargo's `package = "llm-lib"` alias — no source changes needed, `llm_cascade::` call sites are untouched. Verified: `cargo check --workspace` clean, `cargo test -p owner-llm` 6/6 passing.
Member
Author
|
Дублює вже змерджений #26 (та сама першопричина — незакріплені mt-core/llm-cascade git-залежності — знайдена й пофіксена паралельно фоновою сесією раніше, ніж я допушив цей PR). #26 пінить rev на старому історичному коміті в nitra/mt / nitra/7n-rules (band-aid, робочий), тоді як цей PR переносив на нові актуальні репо nitra/mt-rust / перейменований llm-lib (більш forward-looking, але не терміново — #26 вже розблокував CI). Закриваю на користь #26. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проблема
release-owner.ymlпадав на кожному прогоні (включно з новоюowner@X.Y.Zсхемою і зі старою
owner-v*) на кроці build із:Жоден owner-реліз від
owner-v0.15.0не отримав робочого DMG.Корінь
Дві незакріплені (без
rev) git-залежності зowner/src-tauri+app/src-tauri+owner/owner-llmвказували на репо, які з тих піррозділили/перейменували:
mt-core:nitra/mtрозділили на спеку (nitra/mt, лишився) іреалізацію (
nitra/mt-rust, нове).crates/на HEADnitra/mtбільшенемає взагалі — тому кожен
cargo build, який не зловив закешованийправильний checkout, резолвив git-джерело в поточний HEAD
nitra/mt(
3097c91…) замість того, що фактично закріплено вCargo.lock(
03050b8…), і падав.llm-cascade: перейменований наllm-libусерединіnitra/7n-rules(
llm-lib/crates/llm-cascade→llm-lib/crates/llm-lib).app/src-tauriіноді "проскакував" завдяки теплому rust-cache із часів,коли
nitra/mtще мав потрібну структуру — тому цей PR більше про owner,хоч зачіпає обидва Cargo.toml з
mt-core.Зміна
mt-core:git = "nitra/mt.git"→git = "nitra/mt-rust.git"+явний
rev(той самий патерн, що вже є вapp/src-tauri/Cargo.tomlдля
tauri-plugin-agent).llm-cascade(уowner/owner-llm/Cargo.toml):package = "llm-lib"+новий
git/rev— локальна назва вCargo.tomlі всіuse llm_cascade::…у коді лишаються без змін, Cargo сам аліасить перейменований пакет.
Cargo.lockперегенеровано під обидва джерела.Test plan
cargo check --workspace— чистоcargo test -p owner-llm— 6/6 passingrelease-owner.ymlна наступному owner-релізі,підтвердити реальний DMG-артефакт (перший робочий з
owner-v0.15.0)