Skip to content

deps: bump toml from 0.8.23 to 1.0.1+spec-1.1.0#21

Merged
nitecon merged 3 commits intomainfrom
dependabot/cargo/toml-1.0.1spec-1.1.0
Apr 7, 2026
Merged

deps: bump toml from 0.8.23 to 1.0.1+spec-1.1.0#21
nitecon merged 3 commits intomainfrom
dependabot/cargo/toml-1.0.1spec-1.1.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Feb 16, 2026

Bumps toml from 0.8.23 to 1.0.1+spec-1.1.0.

Commits
  • 767747f chore: Release
  • c68aa87 fix(parser): Plug another whole in synthetic events (#1102)
  • 17dc3dd fix(parser): Plug another whole in synthetic events
  • 0f32a02 test(parse): Add another test case
  • 9fef741 docs: Update changelog
  • 3c59611 fix(edit): Remove panics on bad input (#1101)
  • 7968120 fix(edit): On missing value, ensure a span is used
  • b91d460 fix(edit): Don't panic on inline table keys without values
  • c8087a6 fix(parser): Improve unclosed array messages
  • f0a47d4 fix(parser): Improve unclosed inline table messages
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [toml](https://github.com/toml-rs/toml) from 0.8.23 to 1.0.1+spec-1.1.0.
- [Commits](toml-rs/toml@toml-v0.8.23...toml-v1.0.1)

---
updated-dependencies:
- dependency-name: toml
  dependency-version: 1.0.1+spec-1.1.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot bot commented on behalf of github Feb 16, 2026

Labels

The following labels could not be found: rust. Please create it before Dependabot can add it to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

The test module's MockBackend impl uses LoanableBatch in
submit_write() but didn't import it. This was exposed by the
toml dependency bump which triggered a full rebuild.

Fixes CI compilation error E0425 on this Dependabot PR.
@nitecon
Copy link
Copy Markdown
Owner

nitecon commented Apr 6, 2026

🔧 Eventic Auto-Fix: CI Compilation Error

Root cause: The test module in lnc-replication/src/ingestion.rs uses LoanableBatch in the MockBackend::submit_write() impl but was missing the import. The toml dependency bump triggered a full rebuild which exposed this latent issue.

Fix applied: Added use lnc_core::LoanableBatch; to the test imports (commit a803443).


⚠️ Pre-existing: Hot Path Audit Failure

The Hot Path Audit check fails due to Mutex usage in lnc-io/src/uring.rs — this is a pre-existing condition on main, not introduced by this PR. The parking_lot::Mutex wrapping IoUring predates this dependency bump.

Awaiting new CI results after the fix push.

Copy link
Copy Markdown
Owner

@nitecon nitecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incremental Re-Review — Synchronize Event

Overview

New commit a803443 adds a missing LoanableBatch import in lnc-replication/src/ingestion.rs test module, fixing a compilation error (E0425) exposed by the full rebuild from the toml major version bump.

Changes Since Last Review

  • lnc-replication/src/ingestion.rs: Added LoanableBatch to the lnc_core import in the test module. Minimal and correct fix.

Status Check Summary

  • ✅ CodeQL Analyze (actions) — passed
  • ✅ CodeQL Analyze (rust) — passed

Concerns

  • ⚠️ Merge conflicts: The PR currently has merge conflicts (CONFLICTING state). This will need a rebase or merge from main before it can be merged.
  • ⚠️ Major version bump: toml 0.8.23 → 1.0.1 is a semver-major change. The underlying crate renames are notable (toml_edittoml_parser, toml_writetoml_writer, serdeserde_core in transitive deps). While the public API surface of the toml crate appears compatible based on this diff (no application-level code changes needed beyond the import fix), this warrants a quick smoke test beyond CodeQL to ensure serialization/deserialization behavior is unchanged.

Verdict

The import fix itself looks good — it's a correct, minimal change. However, the merge conflicts must be resolved and ideally a build/test CI run (beyond static analysis) should confirm no runtime regressions from the major toml bump before merging.


🤖 Automated review by Eventic

@nitecon nitecon merged commit cdd7d8a into main Apr 7, 2026
21 checks passed
@dependabot dependabot bot deleted the dependabot/cargo/toml-1.0.1spec-1.1.0 branch April 7, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant