deps: bump toml from 0.8.23 to 1.0.1+spec-1.1.0#21
Conversation
Bumps [toml](https://github.com/toml-rs/toml) from 0.8.23 to 1.0.1+spec-1.1.0. - [Commits](toml-rs/toml@toml-v0.8.23...toml-v1.0.1) --- updated-dependencies: - dependency-name: toml dependency-version: 1.0.1+spec-1.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
The test module's MockBackend impl uses LoanableBatch in submit_write() but didn't import it. This was exposed by the toml dependency bump which triggered a full rebuild. Fixes CI compilation error E0425 on this Dependabot PR.
🔧 Eventic Auto-Fix: CI Compilation ErrorRoot cause: The test module in Fix applied: Added
|
nitecon
left a comment
There was a problem hiding this comment.
Incremental Re-Review — Synchronize Event
Overview
New commit a803443 adds a missing LoanableBatch import in lnc-replication/src/ingestion.rs test module, fixing a compilation error (E0425) exposed by the full rebuild from the toml major version bump.
Changes Since Last Review
lnc-replication/src/ingestion.rs: AddedLoanableBatchto thelnc_coreimport in the test module. Minimal and correct fix.
Status Check Summary
- ✅ CodeQL Analyze (actions) — passed
- ✅ CodeQL Analyze (rust) — passed
Concerns
⚠️ Merge conflicts: The PR currently has merge conflicts (CONFLICTINGstate). This will need a rebase or merge frommainbefore it can be merged.⚠️ Major version bump:toml0.8.23 → 1.0.1 is a semver-major change. The underlying crate renames are notable (toml_edit→toml_parser,toml_write→toml_writer,serde→serde_corein transitive deps). While the public API surface of thetomlcrate appears compatible based on this diff (no application-level code changes needed beyond the import fix), this warrants a quick smoke test beyond CodeQL to ensure serialization/deserialization behavior is unchanged.
Verdict
The import fix itself looks good — it's a correct, minimal change. However, the merge conflicts must be resolved and ideally a build/test CI run (beyond static analysis) should confirm no runtime regressions from the major toml bump before merging.
🤖 Automated review by Eventic
Bumps toml from 0.8.23 to 1.0.1+spec-1.1.0.
Commits
767747fchore: Releasec68aa87fix(parser): Plug another whole in synthetic events (#1102)17dc3ddfix(parser): Plug another whole in synthetic events0f32a02test(parse): Add another test case9fef741docs: Update changelog3c59611fix(edit): Remove panics on bad input (#1101)7968120fix(edit): On missing value, ensure a span is usedb91d460fix(edit): Don't panic on inline table keys without valuesc8087a6fix(parser): Improve unclosed array messagesf0a47d4fix(parser): Improve unclosed inline table messagesYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)