forked from ilysenko/codex-desktop-linux
-
Notifications
You must be signed in to change notification settings - Fork 0
docs(sync): add fork sync ledger #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
113 changes: 113 additions & 0 deletions
113
docs/maintainers/fork-sync-ledger/2026-06-03-pr-95-upstream-60c62e3.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| # PR 95 Sync Ledger | ||
|
|
||
| ## Scope | ||
|
|
||
| - PR: [#95](https://github.com/nisavid/codex-app-linux/pull/95) | ||
| - Merge commit: `d8d86a8bd532c8ced34e244737c916eba0264de3` | ||
| - Origin base before sync: `708e2b40b297d85be3503d873cf15389333fb56c` | ||
| - Previous divergence baseline: | ||
| `b771d3d89d8a002d559a443a09a1aa25a4e6702a` | ||
| - Synced Linux-port upstream commit: | ||
| `60c62e38bbd12a5d5ddd4e2bf1d513ff4892fe94` | ||
|
|
||
| ## Incoming Catalog | ||
|
|
||
| ### Remote Mobile Control | ||
|
|
||
| - Keeps the outbound `Control other devices` settings path reachable on Linux. | ||
| - Hardens host, enrollment, and account compatibility matching against current | ||
| official app bundle shapes. | ||
| - Skips unsupported SSH status reads for Linux remote SSH hosts. | ||
| - Improves SSH install and update action handling, including release targeting. | ||
|
|
||
| ### AppShots | ||
|
|
||
| - Bare modifier shortcuts now require distinct left and right modifier keycodes. | ||
| - A fast double-tap on one physical Alt or Shift key no longer opens AppShots. | ||
|
|
||
| ### Webview Patching | ||
|
|
||
| - Adds a required Linux-safe monospace font stack patch for the official | ||
| webview font settings bundle. | ||
| - Adapts rate-limit footer patching to current official composer bundle shapes. | ||
| - Moves the fast-mode model guard to an extracted-app patch and hardens | ||
| detection so a missing relevant webview asset warns and fails the required | ||
| gate instead of being recorded as already applied. | ||
|
|
||
| ### Build And Package Metadata | ||
|
|
||
| - Build metadata now records sanitized GitHub commit URLs. | ||
| - The generated app build-information dialog can show an `Open Commit` action | ||
| when a safe GitHub commit URL is available. | ||
| - Package staging recovers when the configured updater binary source points at a | ||
| deleted rebuilt artifact by using the rebuilt release binary path. | ||
|
|
||
| ### Nix And Updater Trust | ||
|
|
||
| - Refreshed the official DMG Nix pin to app version `26.601.21317`. | ||
| - Updated `updater/trusted-dmg-manifest.json` to the matching official DMG | ||
| SHA-256. | ||
|
|
||
| ### Docs And Tests | ||
|
|
||
| - Updated the fork divergence baseline to the synced Linux-port upstream commit. | ||
| - Added or expanded coverage for AppShots, remote mobile control, webview | ||
| patching, package-builder deleted-updater-source recovery, and script smoke | ||
| behavior. | ||
|
|
||
| ## Local Reconciliation | ||
|
|
||
| - Upstream `linux-features/appshots/*` changes were ported into | ||
| `port-integrations/appshots/*`. | ||
| - Upstream `linux-features/remote-mobile-control/*` changes were ported into | ||
| `port-integrations/remote-mobile-control/*`. | ||
| - The descriptor prefix remains `integration:`. | ||
| - Durable docs keep `port integration` terminology. | ||
| - Local product and package names remain `codex-app` and | ||
| `codex-app-updater`. | ||
| - XDG/FHS package layout and the unprivileged updater boundary are preserved. | ||
| - Package versioning still follows the official OpenAI app bundle version. | ||
|
|
||
| ## Special Handling And Follow-Up | ||
|
|
||
| - Remote mobile control remains experimental. Existing issue | ||
| [#59](https://github.com/nisavid/codex-app-linux/issues/59) covers the | ||
| human-assisted live account, mobile authorization, and host-state review, so | ||
| this sync did not need a new remote-control issue. | ||
| - AppShots same-key double-tap behavior changed intentionally. No follow-up | ||
| issue is warranted unless user reports show the distinct-left-right behavior | ||
| is too surprising. | ||
| - Fast-mode guard missing-candidate failures are now meaningful official bundle | ||
| drift signals. Treat future failures as patch compatibility work, not generic | ||
| CI flakiness. No separate issue is warranted from this sync. | ||
| - Nix DMG pins and updater trusted-DMG metadata must stay in lockstep on future | ||
| DMG refreshes. The policy and this ledger capture that expectation; no | ||
| separate issue is warranted. | ||
| - Linux monospace fallback changed. No issue is warranted without visual | ||
| regression evidence. | ||
| - Retroactive ledger coverage for earlier fork syncs is tracked in | ||
| [#96](https://github.com/nisavid/codex-app-linux/issues/96). | ||
|
|
||
| ## Verification | ||
|
|
||
| - `node --test port-integrations/appshots/test.js` passed. | ||
| - `node --test port-integrations/remote-mobile-control/test.js` passed. | ||
| - `node --test scripts/patch-linux-window-ui.test.js` passed. | ||
| - `node --test --test-name-pattern "fast-mode" scripts/patch-linux-window-ui.test.js` | ||
| passed. | ||
| - `node --check scripts/patches/webview-assets.js` passed. | ||
| - `node --check scripts/patches/core/all-linux/webview/fast-mode-guard/patch.js` | ||
| passed. | ||
| - `bash -n tests/scripts_smoke.sh scripts/lib/package-common.sh` passed. | ||
| - `bash tests/scripts_smoke.sh` passed. | ||
| - `cargo test -p codex-app-updater trust` passed. | ||
| - `scripts/ci/validate-nix-pins.sh Codex.dmg` passed. | ||
| - `env CODEX_PATCH_REPORT_JSON=/tmp/codex-pr95-patch-report-current-shape-fix.json make build-app` | ||
| passed using cached `Codex.dmg` from `2026-06-02 20:09:09 -0400`, app | ||
| version `26.601.21317`. | ||
| - `node scripts/ci/validate-patch-report.js /tmp/codex-pr95-patch-report-current-shape-fix.json --profile official-dmg-build` | ||
| passed; `linux-fast-mode-model-guard` reported `already-applied`. | ||
| - `git diff --check` passed. | ||
| - Final PR checks passed, including Official DMG Build, Nix Package Builds, | ||
| Debian, RPM, pacman, updater, smoke tests, CodeQL, clippy, CodeRabbit, and | ||
| Greptile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # Fork Sync Ledger | ||
|
|
||
| This directory holds durable summaries for broad syncs from the Linux-port | ||
| upstream into this fork. Keep the PR body concise, but copy the final sync | ||
| ledger here before closeout so future syncs can review prior imported behavior, | ||
| special handling, and follow-up decisions without searching old PR text. | ||
|
|
||
| Use one file per broad sync: | ||
|
|
||
| ```text | ||
| YYYY-MM-DD-pr-NN-upstream-SHORTSHA.md | ||
| ``` | ||
|
|
||
| Each entry should include: | ||
|
|
||
| - sync scope: PR, merge commit, base commit, previous baseline, and synced | ||
| Linux-port upstream commit; | ||
| - upstream commit catalog grouped by behavior area; | ||
| - local reconciliation notes for renamed paths and fork contracts; | ||
| - user-facing or maintainer-facing highlights that may need special handling; | ||
| - follow-up decision for each special-handling item, including links to existing | ||
| issues or a note that no new issue is warranted; | ||
| - verification evidence from local gates and final PR checks. | ||
|
|
||
| Do not record secrets, local-only credentials, or full generated artifacts in | ||
| the ledger. Link to PRs, issues, docs, and commands instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.