Skip to content

test: guard rig convention docs drift - #128

Open
zerone0x wants to merge 1 commit into
nirholas:mainfrom
zerone0x:fix-rig-conventions-drift-test
Open

test: guard rig convention docs drift#128
zerone0x wants to merge 1 commit into
nirholas:mainfrom
zerone0x:fix-rig-conventions-drift-test

Conversation

@zerone0x

Copy link
Copy Markdown

What & why

Adds a mechanical drift guard for the Rig Doctor convention list.

Closes #114

The test reads the recognised rig conventions table from docs/rig-doctor.md and compares its convention labels to the detector's exported CONVENTIONS list. It also asserts every implemented convention has non-empty user-facing evidence text.

Type of change

  • Feature
  • Improvement
  • Fix
  • Docs
  • Infra / chore (no user-visible effect)

Definition of done

  • Code is fully wired and reachable by the user — no dead paths, stubs, TODOs, or commented-out code.
  • No mocks, fake data, or placeholder values — real APIs and real data only.
  • Every interactive element has hover, active, and focus states (UI changes).
  • Loading, empty, and error states are designed and helpful (UI changes).
  • npm test passes and npm run typecheck is clean.
  • npm run lint is clean (or only pre-existing warnings).
  • I reviewed my own git diff — every changed line is justified.

Verification

  • npx vitest run tests/rig-report.test.js — 22 tests passed.
  • Drift proof: temporarily removed the Mixamo row from docs/rig-doctor.md; npx vitest run tests/rig-report.test.js failed with expected [ 'Ready Player Me', …(10) ] to deeply equal [ 'Ready Player Me', 'Mixamo', …(10) ]; restored the row and reran the focused suite successfully.
  • npm run typecheck currently fails on unrelated existing errors in api/_lib/brownout/provenance.js, api/_lib/ops/x402-settle-health.js, api/_lib/sniper-solvency.js, and api/_lib/upstream-fetch.js.
  • npm run lint -- --quiet currently fails on unrelated existing errors in packages/metaplex-agent-mcp/docs/app.js and src/categories.js.

Changelog

  • Added a data/changelog.json entry, or this change is internal-only and needs none.

Screenshots / recordings

Not applicable; test-only change.

@zerone0x
zerone0x requested a review from nirholas as a code owner August 29, 2026 20:07
@vercel

vercel Bot commented Aug 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
three-ws Error Error Aug 29, 2026 8:07pm

@vercel
vercel Bot temporarily deployed to Preview – three-ws August 29, 2026 20:07 Inactive
@nirholas

Copy link
Copy Markdown
Owner

looking into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests: guard against drift between the rig conventions we support and the ones we document

2 participants