test: guard rig convention docs drift - #128
Open
zerone0x wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
|
looking into this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Adds a mechanical drift guard for the Rig Doctor convention list.
Closes #114
The test reads the recognised rig conventions table from
docs/rig-doctor.mdand compares its convention labels to the detector's exportedCONVENTIONSlist. It also asserts every implemented convention has non-empty user-facingevidencetext.Type of change
Definition of done
npm testpasses andnpm run typecheckis clean.npm run lintis clean (or only pre-existing warnings).git diff— every changed line is justified.Verification
npx vitest run tests/rig-report.test.js— 22 tests passed.Mixamorow fromdocs/rig-doctor.md;npx vitest run tests/rig-report.test.jsfailed withexpected [ 'Ready Player Me', …(10) ] to deeply equal [ 'Ready Player Me', 'Mixamo', …(10) ]; restored the row and reran the focused suite successfully.npm run typecheckcurrently fails on unrelated existing errors inapi/_lib/brownout/provenance.js,api/_lib/ops/x402-settle-health.js,api/_lib/sniper-solvency.js, andapi/_lib/upstream-fetch.js.npm run lint -- --quietcurrently fails on unrelated existing errors inpackages/metaplex-agent-mcp/docs/app.jsandsrc/categories.js.Changelog
data/changelog.jsonentry, or this change is internal-only and needs none.Screenshots / recordings
Not applicable; test-only change.