ENH: Improve memory estimates for dense PET and GTM workflows - #328
Open
mnoergaard wants to merge 4 commits into
Open
mnoergaard wants to merge 4 commits into
mnoergaard wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
==========================================
+ Coverage 86.24% 86.38% +0.14%
==========================================
Files 88 88
Lines 9988 10115 +127
Branches 1056 1064 +8
==========================================
+ Hits 8614 8738 +124
- Misses 1143 1145 +2
- Partials 231 232 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes PETPrep’s Nipype scheduling more conservative for memory-heavy PET workflows.
Changes include:
This should reduce BrokenProcessPool failures caused by underestimating memory and running too many large nodes concurrently.