feat: preserve pre-existing group members in mutable mode#40
Open
jfroche wants to merge 1 commit intonikstur:mainfrom
Open
feat: preserve pre-existing group members in mutable mode#40jfroche wants to merge 1 commit intonikstur:mainfrom
jfroche wants to merge 1 commit intonikstur:mainfrom
Conversation
Users added to groups before userborn activation are currently removed on activation. This commit changes the behavior in mutable users mode to preserve pre-existing group members. Group membership updates are now the union of existing and configured members instead of replacing. On deactivation, only the configured members are removed, preserving any pre-existing members that were added before userborn activation. In immutable mode, the previous behavior of replacing group members entirely on activation is retained.
Author
|
Note that we don't preserve the original order of the list of users in the group as we are using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, users added to groups before userborn activation were removed when userborn ran.
In mutable users mode, group membership updates now preserve pre-existing members while still allowing configured members to be added or removed.
On deactivation, only the configured members are removed, preserving any pre-existing members that were added before userborn activation.
In immutable mode, the previous behavior of replacing group members entirely on activation is retained.