fix undefined behavior in EOCD backward scan #516
+23
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes undefined behavior in the End Of Central Directory (EOCD)
signature search used when opening ZIP archives.
The previous implementation scanned backward using a pointer-decrement
loop of the form
p >= data; p -= 1. When the scan reached the start ofthe buffer, the subsequent decrement constructed an out-of-bounds
pointer (
data - 1), which is undefined behavior in C. Under hardenedbuilds or sanitizers, this can result in process aborts.
Changes
never constructs pointers outside the allocated buffer
lastremains within the buffer
Impact
Testing
-fsanitize=undefined