Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ❌ | rawdata not moved to data/raw |
| Part 1 - Q3 | ❌ | ls command run on wrong directory |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ❌ | No server log files in data/raw |
| Part 1 - Q6 | ❌ | No user log files in data/raw; No event log files in data/raw |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ❌ | data/inventory.txt does not exist |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ❌ | rawdata not moved to data/raw |
| Part 1 - Q3 | ❌ | ls command run on wrong directory |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ❌ | No server log files in data/raw |
| Part 1 - Q6 | ❌ | No user log files in data/raw; No event log files in data/raw |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ❌ | data/inventory.txt does not exist |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ❌ | rawdata not moved to data/raw |
| Part 1 - Q3 | ❌ | ls command run on wrong directory |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ❌ | No server log files in data/raw |
| Part 1 - Q6 | ❌ | No user log files in data/raw; No event log files in data/raw |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ❌ | data/inventory.txt does not exist |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ✅ | |
| Part 1 - Q6 | ✅ | |
| Part 1 - Q7 | ❌ | One or more files with ipaddr in data/raw not removed.; One or more files with ipaddr in data/processed/user_logs not removed |
| Part 1 - Q8 | ✅ | |
| Part 2 | ✅ |
Please address the issues listed above.
| # Complete assignment here | ||
|
|
||
| # 1. Create a directory named data | ||
| cd newproject |
There was a problem hiding this comment.
cd newproject line is not needed because the folder is used for testing. Please delete this line,
anjali-deshpande-hub
left a comment
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Please delete the two lines of code mentioned in the comments. Everything else looks good. Thank you
| # 7. For user privacy, remove all files containing IP addresses (files with "ipaddr" in the filename) from ./data/raw and ./data/processed/user_logs | ||
| rm -f data/raw/*ipaddr* | ||
| rm -f data/processed/user_logs/*ipaddr* | ||
| rf -rf ./data |
There was a problem hiding this comment.
The rf -rf ./data code should be deleted when resolving conflicts on merging coworker-changes branch changes with assignment branch. Its incorrect code which is attempting to delete data directory. Please delete this line of code
anjali-deshpande-hub
left a comment
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Perfect! The changes look good.
3 participants
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code.
What did you learn from the changes you have made?
Learnt how to run code and make edits.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I initially wrote all the commands manually in Terminal, but then I had to default to VS and bashed the script.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I mixed up the repositories and the branches, which led to problems creating a pull request.
How were these changes tested?
I bashed the script.
A reference to a related issue in your repository (if applicable)
Checklist