Add LKMA-209 synthetic ground-truth recordings - #17
Conversation
Co-Authored-By: Paperclip <noreply@paperclip.ing>
Code Review — LKMA-210 (Reviewer verdict)
Reviewed
ChecklistBranch hygiene ✅ All 7 required files ✅ WAV format ✅ V.21 signal quality ✅ V.22bis placeholders ✅ Report JSON ✅ C source ( Known caveat — accepted
VERDICT: APPROVED — recordings are correct, format-clean, and match the LKMA-209 spec. Safe to merge. LKMA-209 remains blocked pending LKMA-195. |
Summary
Verification
Bench note
The repository main branch does not yet contain vendor/sipfax-softmodem. Against the current LKMA-195 softmodem branch, the generated WAV reaches data-mode, then the worker segfaults after v8-failed-v21-fallback before decoding. That prevents the literal bench-v21.py acceptance from completing until the softmodem branch is fixed/merged.