better double threats and more appropriate data transfers for double actions - #55
better double threats and more appropriate data transfers for double actions#55slinkymanbyday wants to merge 5 commits into
Conversation
|
In regards to German translation, I used Google translate, can be updated with someone who knows German |
|
Please look at adding tests for this is important for sanity, and yea it would help to do the refactor separate from the changes you want so we can have more sanity if we need to rollback... not sure what is going on with circleci build... I think I will try and move to github actions now that open source has some free credits |
| <string name="pref_incoming_data_title">Eingehende Daten: %1$d - %2$d</string> | ||
| <string name="pref_incoming_data_dialog_title">Eingehende Daten</string> | ||
| <string name="pref_incoming_data_summary">Spielraum der eingehenden Daten</string> | ||
| <string name="pref_data_transfer_title">Datentransfer: %1$d - %2$d</string> |
There was a problem hiding this comment.
Please put a on top of all the ones you did that way please
There was a problem hiding this comment.
not sure what is meant by this. could you clarify?
There was a problem hiding this comment.
Oh my message got truncated I was saying put a comment of Google translated above each of these so others can help us review
| // generate threats | ||
| boolean generated = false; | ||
| int tries = 100; //maximum number of tries to generate mission | ||
| int tries = 500; //maximum number of tries to generate mission |
There was a problem hiding this comment.
mistake left over from some of my testing.
Also realised i missed out on docstrings and spotted some spelling mistakes in comments. I'll get that fixed up and update the PR
|
Also I can't fully tell from what you have done, but are you considering the swap between normal missions and double actions configurations? My thoughts is it should reset to expected ranges as you swap between them |
This would be nice, but i'm not sure how to accomplish that. |
No worries, I can help with that, you inspired me to work on finishing the move to coroutines as well so will maybe get this code base cleaned up and have it more obvious when random missions are generated as well =) |
2 participants
Apologies for large single commit.
You you want I can break it down into smaller commits.
Will still play test this a bit the next change a get (normally play every few weeks).
I only play double action missions, however I think my changes should be ok for single action missions too.