Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Error handling can falsely report successful queueing and leave Azure DevOps runs active after polling failures.
2 open findings
What changed in this PR
Adds GitHub Actions integration with Azure DevOps for PR validation and revision updates.
Changes:
- Triggers and monitors Azure DevOps PR builds.
- Triggers revision updates after pushes to
ni/main. - Cancels superseded Azure DevOps PR runs.
| File | Description |
|---|---|
.github/workflows/trigger-azdo-pr-pipeline.yml |
Queues, monitors, and cancels PR builds. |
.github/workflows/trigger-azdo-revision-update.yml |
Queues revision-update pipelines. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ggrigory
marked this pull request as ready for review
October 16, 2026 08:00
Collaborator
|
From a functional standpoint it looks good, the PR pipeline is correctly triggered in azdo from Github. @szb640 can you check also this PR? |
szb640
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two workflows that connect ni/vsomeip to the srd-tran-vehicle-networks AzDO pipelines:
"trigger-azdo-pr-pipeline.yml": on PRs targeting "ni/main" (skips drafts and fork PRs), queues the AzDO someip PR pipeline, waits for the result, and cancels the AzDO run when superseded or cancelled.
"trigger-azdo-revision-update.yml": on push to "ni/main", queues the AzDO pipeline that updates "vsomeip-revision.txt". On success, that pipeline opens an auto-complete PR in srd-tran-vehicle-networks that updates "someip/vsomeip/vsomeip-revision.txt" to the new "ni/main" SHA. When that PR merges to "main", the AzDO someip CI pipeline triggers automatically, so it builds and tests the pinned revision right away.