Repository navigation
setup-poetry: Update default Poetry version to 2.4.1 #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bkeryan
wants to merge
1
commit into
main
Choose a base branch
from
users/bkeryan/update-default-poetry-version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ name: Set up Poetry | |
| description: Install Poetry, add it to the PATH, and cache it to speed up workflows. | ||
| inputs: | ||
| poetry-version: | ||
| default: 2.1.4 | ||
| default: 2.4.1 | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. re PR build, let's stop validating 3.9 |
||
| use-cache: | ||
| description: > | ||
| A Boolean specifying whether to use the cache. Set this to false to work | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
observations:
@mshafer-NI
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mshafer-NI I rebased against main and now it's only failing with pypy3.11. https://github.com/ni/python-actions/actions/runs/38440770800/job/115446447740
analyze-project is still downgrading click, isort, and platformdirs to the versions that support Python 3.9 (?). Has Poetry's behavior changed here?
analyze-project with 3.10 is still installing click 8.1.8 instead of click 8.3.0, but it doesn't fail because there's no longer a cache hit.
setup-poetry tests are failing on
poetry --version.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple things I think are playing in looking at the log (+ your comment).
Poetry (lock) tries to pick a single version of any dep that satisfies the entire supported range of the package. If we need different versions of dep X for different py versions, we have to explicitly tell click to do that.
I suspect we need to add a
poetry env use pythonto get poetry to use the currently selected Python interpreter correctly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be related to actions/setup-python#1348
actions/setup-pythonis unconditionally installing the latestpipwhen it installspypy, and it's using--ignore-installedrather than upgrading. The result is a mixture of the old and new pip packages.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can reproduce this behavior locally without
actions/setup-pythonThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
poetry.lock contains click 8.1.8 and 8.3.0.
poetry 2.1.4 installed click 8.3.0 with the same poetry.lock file: https://github.com/ni/python-actions/actions/runs/38318779270/job/115041634642
Installing Poetry using the selected Python was intended to avoid this, and in the past, it worked. Otherwise we might as well use pipx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, a problem with
poetry env use pythonis that it must be done once per venv, not once per Poetry, soni/python-actions/setup-poetrycan't do it for you.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is somehow related to
backports.zstd.\poetry-pypy\Lib\site-packages\backports\zstd\_zstd_cffi.pypy311-pp80-win_amd64.pydexists, though.