Repository navigation
Package and dependency migration to poetry - #6
Conversation
|
Hi @ni-jfitzger , Please review the PR with below mentioned scope of work and share your feedback.
|
|
We're still triggering the Publish workflow off of changes to the VERSION file, even though pyproject.toml isn't using it. Don't worry about adding a workflow_dispatch trigger. That can be done with the rest of the workflow changes that will come later. And we should be able to delete the VERSION file, as well. |
Thanks for the suggestion. I've updated the publish workflow to trigger on release.published, removed the dependency on the VERSION file, and removed the unused VERSION file. I'll leave the additional workflow modernization (workflow_dispatch) which doesn't fit for this PR scope, in later workflow/pypi publishing PR. |
What does this Pull Request accomplish?
Why should this Pull Request be merged?
What testing has been done?
poetry installpoetry run pytestpoetry run flake8poetry build