-
Notifications
You must be signed in to change notification settings - Fork 100
Update nidcpower_measure_record.py #2159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Line 18 has typo where it should be 1 / session.measure_record_delta_time not session.measure_record_delta_time/1
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #2159 +/- ##
==========================================
- Coverage 90.07% 82.37% -7.71%
==========================================
Files 71 55 -16
Lines 18666 11803 -6863
==========================================
- Hits 16814 9723 -7091
- Misses 1852 2080 +228
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
vnktshr21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR description to be in the template format. You could refer previously submitted PRs for how to write the description.
@vnktshr21 PR description updated. |
|
Please affirm that your contribution adheres to the CONTRIBUTING.md (you should have seen comments about this, initially). Strike through the other checkbox lines. They don't apply. |
Done @ni-jfitzger . Sorry for missing this and that. This is my very first contribution to an open source project :) |
ni-jfitzger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert on the nidcpower API, but given that the unit for measure_record_delta_time is seconds, this change seems correct to me.
|
The example fails with
|
- [ ] I've updated CHANGELOG.md if applicable.- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Fixed typo in line 18 where effective measurement rate is divide by 1 (which is incorrect).
List issues fixed by this Pull Request below, if any.
None
What testing has been done?
Python code run fine with the measurement rate display correctly