Skip to content

Conversation

@rajsite
Copy link
Member

@rajsite rajsite commented Jan 14, 2026

Pull Request

🤨 Rationale

Refactor the Icon base class so new types of icons can extend the class manually. Should be a non-breaking change for users as existing icon api and paths don't change. Intention is to support custom icon types such as multicolor icons (#327) and dynamic icons (#2813).

👩‍💻 Implementation

  • Refactor the Icon base class to be abstract
  • Make a new SVGIcon base class that implements the current infrastructure for nimble icons

🧪 Testing

  • Rely on existing tests

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@rajsite rajsite changed the title SVGIcon prototype Refactor Icon base class Jan 23, 2026
@rajsite rajsite marked this pull request as ready for review January 23, 2026 18:13
@rajsite rajsite changed the title Refactor Icon base class Refactor Icon base class to be extendable Jan 23, 2026
@rajsite rajsite merged commit ea48f0f into main Jan 23, 2026
11 checks passed
@rajsite rajsite deleted the icon-refactor branch January 23, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants