Skip to content

fix: make control_msgs optional - #5

Open
dancher00 wants to merge 1 commit into
ngres:mainfrom
dancher00:fix/optional-control-msgs
Open

fix: make control_msgs optional#5
dancher00 wants to merge 1 commit into
ngres:mainfrom
dancher00:fix/optional-control-msgs

Conversation

@dancher00

Copy link
Copy Markdown

Summary

  • lazy-load control_msgs only when parallel_gripper_action is selected
  • keep the component factory and all non-gripper components importable without control_msgs
  • document the optional ROS package and add regression coverage

The source-install commands reported in #2 were already corrected by c8ca08b; this addresses the remaining import-time dependency.

Tests

  • pytest tests/test_optional_control_msgs.py -q — 2 passed
  • ruff check and ruff format --check — passed
  • the pre-existing test_get_state_sees_live_messages passes in isolation but remains order-dependent after test_state_node_is_not_in_the_executor

Fixes #2

Load control_msgs only when the parallel gripper component is selected, document its ROS package, and cover dependency-free imports with regression tests.

Fixes ngres#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install: packages not published on PyPI, and undocumented control_msgs dependency

1 participant