fix: make control_msgs optional - #5
Open
dancher00 wants to merge 1 commit into
Open
Conversation
Load control_msgs only when the parallel gripper component is selected, document its ROS package, and cover dependency-free imports with regression tests. Fixes ngres#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
control_msgsonly whenparallel_gripper_actionis selectedcontrol_msgsThe source-install commands reported in #2 were already corrected by c8ca08b; this addresses the remaining import-time dependency.
Tests
pytest tests/test_optional_control_msgs.py -q— 2 passedruff checkandruff format --check— passedtest_get_state_sees_live_messagespasses in isolation but remains order-dependent aftertest_state_node_is_not_in_the_executorFixes #2