Skip to content

Fix typo in NGINX Plus error response struct - #1948

Merged
Akshay2191 merged 2 commits into
mainfrom
fix/error-response-json-typo
Oct 2, 2026
Merged

Akshay2191 merged 2 commits into
mainfrom
fix/error-response-json-typo

Conversation

@dhurley

@dhurley dhurley commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

Proposed changes

Fix typo in NGINX Plus error response struct.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley
dhurley requested a review from a team as a code owner September 30, 2026 12:27
@github-actions github-actions Bot added bug Something isn't working chore Pull requests for routine tasks labels Sep 30, 2026
@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.91%. Comparing base (b8b0995) to head (5864946).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1948      +/-   ##
==========================================
- Coverage   88.91%   88.91%   -0.01%     
==========================================
  Files         111      111              
  Lines       12426    12426              
==========================================
- Hits        11049    11048       -1     
- Misses       1375     1376       +1     
  Partials        2        2              
Files with missing lines Coverage Δ
internal/nginx/nginx_plugin.go 80.97% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8b0995...5864946. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dhurley dhurley added the v3.x Issues and Pull Requests related to the major version v3 label Sep 30, 2026
@Akshay2191
Akshay2191 force-pushed the fix/error-response-json-typo branch from a204f4a to 29af6d7 Compare October 2, 2026 10:43
@Akshay2191
Akshay2191 merged commit 5b9c815 into main Oct 2, 2026
65 of 70 checks passed
@Akshay2191
Akshay2191 deleted the fix/error-response-json-typo branch October 2, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working chore Pull requests for routine tasks dependencies v3.x Issues and Pull Requests related to the major version v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants