Skip to content

adding a filetype check - #1947

Merged
Akshay2191 merged 2 commits into
mainfrom
adding-filetype-check
Oct 2, 2026
Merged

Akshay2191 merged 2 commits into
mainfrom
adding-filetype-check

Conversation

@Akshay2191

Copy link
Copy Markdown
Collaborator

Adding file type check to prevent Agent blocking on non-regular files during config apply.

@Akshay2191
Akshay2191 requested a review from a team as a code owner September 29, 2026 11:04
@github-actions github-actions Bot added the chore Pull requests for routine tasks label Sep 29, 2026
@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.91%. Comparing base (cea3092) to head (3cb2cb5).

Files with missing lines Patch % Lines
internal/file/file_service_operator.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1947      +/-   ##
==========================================
- Coverage   88.94%   88.91%   -0.03%     
==========================================
  Files         111      111              
  Lines       12426    12444      +18     
==========================================
+ Hits        11052    11065      +13     
- Misses       1372     1377       +5     
  Partials        2        2              
Files with missing lines Coverage Δ
internal/file/file_operator.go 76.27% <100.00%> (+0.37%) ⬆️
internal/watcher/file/file_watcher_service.go 86.75% <100.00%> (+0.74%) ⬆️
internal/file/file_service_operator.go 85.88% <87.50%> (+0.17%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea3092...3cb2cb5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread internal/file/file_service_operator.go Outdated
@oCHRISo oCHRISo added the v3.x Issues and Pull Requests related to the major version v3 label Sep 30, 2026
@Akshay2191
Akshay2191 force-pushed the adding-filetype-check branch from dbe3d42 to 3cb2cb5 Compare October 2, 2026 15:52
@Akshay2191
Akshay2191 merged commit b7eee30 into main Oct 2, 2026
66 of 70 checks passed
@Akshay2191
Akshay2191 deleted the adding-filetype-check branch October 2, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants