Skip to content

Report a failed move to the backup location as a failed backup to Zabbix #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cfoellmann wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Report a failed move to the backup location as a failed backup to Zabbix #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
## 4.9.3 2026-08-30 <foellmann at wus-technik dot com>

### Changed
- Report a failed move to the backup location as a failed backup to Zabbix, so that the
`[{#NAME}] Backup - Failed with errors` trigger fires when a dump never reached its
destination


## 4.9.2 2026-08-24 <code at nfrastack dot com>

### Changed
Expand Down
7 changes: 6 additions & 1 deletion rootfs/container/functions/10-dbbackup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1630,10 +1630,15 @@ dbbackup_post_dbbackup() {
silent dbbackup_run_as_user zabbix_sender -c "${ZABBIX_CONFIG_PATH}"/"${ZABBIX_CONFIG_FILE}" -k dbbackup.backup -o '[{"{#NAME}":"'${backup_job_db_host}.${backup_job_db_name}'"}]'
local zabbix_payload=$(dbbackup_run_as_user mktemp)

## The backup only counts as successful when it also reached its destination -
## exit_code covers the dump alone, move_exit_code the move to the backup location.
local zabbix_status="${exit_code}"
if [ "${move_exit_code:-0}" != "0" ] ; then zabbix_status=1 ; fi

cat <<EOZP | silent dbbackup_run_as_user tee "${zabbix_payload}"
- dbbackup.backup.size.[${backup_job_db_host}.${backup_job_db_name}] "${dbbackup_size}"
- dbbackup.backup.datetime.[${backup_job_db_host}.${backup_job_db_name}] "${dbbackup_date}"
- dbbackup.backup.status.[${backup_job_db_host}.${backup_job_db_name}] "${exit_code}"
- dbbackup.backup.status.[${backup_job_db_host}.${backup_job_db_name}] "${zabbix_status}"
- dbbackup.backup.duration.[${backup_job_db_host}.${backup_job_db_name}] "$((dbbackup_finish_time-dbbackup_start_time))"
- dbbackup.backup.filename.[${backup_job_db_host}.${backup_job_db_name}] "${backup_job_filename}"
EOZP
Expand Down