Skip to content

fix: add missing accessibility labels in header and storage quota #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
memurats merged 1 commit into from
Jul 10, 2026
Merged

fix: add missing accessibility labels in header and storage quota #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions l10n/de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
"Toggle grid view": "Ansicht ändern",
"Display settings": "Anzeigeeinstellungen",
"Expand storage": "Speicherplatz erweitern",
"Expand storage, opens in new tab": "Speicherplatz erweitern, öffnet in neuem Tab",
"Memory used up to %s%%": "Speicher zu %s%% belegt ",
"of": "von",
"Delete file" : "Datei löschen",
Expand Down Expand Up @@ -258,7 +259,9 @@
"Impressum": "Impressum",
"Data protection": "Datenschutz",
"Faq": "Hilfe & FAQ",
"opens in new tab": "öffnet in neuem Tab",
"Expand storage": "Speicher erweitern",
"Expand storage, opens in new tab": "Speicher erweitern, öffnet in neuem Tab",
"Storage at {percentage}% used": "Speicher zu {percentage}% belegt",
"of": "von",
"used": "genutzt",
Expand Down
5 changes: 4 additions & 1 deletion l10n/de_DE.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@
"Toggle grid view": "Ansicht ändern",
"Display settings": "Anzeigeeinstellungen",
"Expand storage": "Speicherplatz erweitern",
"Memory used up to %s%%": "Speicher zu %s%% belegt ",
"Expand storage, opens in new tab": "Speicherplatz erweitern, öffnet in neuem Tab",
"Memory used up to %s%%":"Speicher zu %s%% belegt ",
"of": "von",
"Delete file" : "Datei löschen",
"Delete folder" : "Ordner löschen",
Expand Down Expand Up @@ -258,7 +259,9 @@
"Impressum": "Impressum",
"Data protection": "Datenschutz",
"Faq": "Hilfe & FAQ",
"opens in new tab": "öffnet in neuem Tab",
"Expand storage": "Speicher erweitern",
"Expand storage, opens in new tab": "Speicher erweitern, öffnet in neuem Tab",
"Storage at {percentage}% used": "Speicher zu {percentage}% belegt",
"of": "von",
"used": "genutzt",
Expand Down
3 changes: 3 additions & 0 deletions l10n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
"Toggle grid view": "Toggle grid view",
"Display settings": "Display settings",
"Expand storage": "Expand storage",
"Expand storage, opens in new tab": "Expand storage, opens in new tab",
"Memory used up to %s%%": "Memory used up to %s%%",
"of": "von",
"_including %n hidden_::_including %n hidden_": ["with %n hidden","with %n hidden"],
Expand Down Expand Up @@ -224,7 +225,9 @@
"Impressum": "Impressum",
"Data protection": "Data protection",
"Faq": "Help & FAQ",
"opens in new tab": "opens in new tab",
"Expand storage": "Expand storage",
"Expand storage, opens in new tab": "Expand storage, opens in new tab",
"Storage at {percentage}% used": "Storage at {percentage}% used",
"of": "of",
"used": "used",
Expand Down
3 changes: 3 additions & 0 deletions l10n/en_GB.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
"Toggle grid view": "Toggle grid view",
"Display settings": "Display settings",
"Expand storage": "Expand storage",
"Expand storage, opens in new tab": "Expand storage, opens in new tab",
"Memory used up to %s%%": "Memory used up to %s%%",
"of": "von",
"_including %n hidden_::_including %n hidden_": ["with %n hidden","with %n hidden"],
Expand Down Expand Up @@ -224,7 +225,9 @@
"Impressum": "Impressum",
"Data protection": "Data protection",
"Faq": "Help & FAQ",
"opens in new tab": "opens in new tab",
"Expand storage": "Expand storage",
"Expand storage, opens in new tab": "Expand storage, opens in new tab",
"Storage at {percentage}% used": "Storage at {percentage}% used",
"of": "of",
"used": "used",
Expand Down
5 changes: 3 additions & 2 deletions src/components/StorageQuota.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@
<a class="storage-quota__link"
target="_blank"
rel="noopener"
href="https://cloud.telekom-dienste.de/tarife">
<NcIconSvgWrapper :svg="cloudIconSvg" class="storage-quota__link-icon" />
href="https://cloud.telekom-dienste.de/tarife"
:aria-label="t('nmctheme', 'Expand storage, opens in new tab')">
<NcIconSvgWrapper :svg="cloudIconSvg" class="storage-quota__link-icon" aria-hidden="true" />
{{ t('nmctheme', 'Expand storage') }}
</a>
</div>
Expand Down
8 changes: 5 additions & 3 deletions src/components/UserMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
<template>
<div>
<template>
<li v-for="item in items"
:id="item.id"
:key="item.id"
class="menu-entry">
<a :href="item.url" :target="item.target">
<a :href="item.url"
:target="item.target"
:aria-label="item.target === '_blank' ? t('nmcsettings', item.name) + ', ' + t('nmctheme', 'opens in new tab') : null">
<span>{{ t('nmcsettings', item.name) }}</span>
</a>
</li>
</div>
</template>
</template>

<script>
Expand Down
Loading