fix: add missing accessibility label on E-Mail header link#19
Open
suet-kei-chan wants to merge 1 commit into
Open
fix: add missing accessibility label on E-Mail header link#19suet-kei-chan wants to merge 1 commit into
suet-kei-chan wants to merge 1 commit into
Conversation
The E-Mail link in the header had no accessible name for screen readers despite having visible text and opening in a new tab. Changes: - Add aria-label to the <a> element composing the email text with the unread count when applicable (e.g. "E-Mail, 12 unread, opens in new tab") and always appending ", opens in new tab" to inform screen readers that the link opens in a new browser tab - Add aria-hidden="true" to the mail icon, unread badge, and label <div> to prevent screen readers from double-announcing the content already covered by the aria-label on the parent link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The E-Mail link in the header had no accessible name for screen readers despite having visible text and opening in a new tab.
Changes: