Repository navigation
fix(images): accept service-binding tickets in widget - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and fix
0.5.0-beta.4issues service-binding image tickets ass.<service-id>.<ciphertext>, but the widget accepted only untagged base64url tickets and fell back to alt text. Accept both bounded formats while continuing to reject malformed tags and query injection.Relates to #9. The separate Windows PHP locking limitation remains open.
Verification
vitest run test/widget-markdown-images.test.ts test/server-image-route.test.ts: 23 passed, including a real handler-to-ApiClient ticket and image redemption and malformed ticket tests.git diff --checkpassed.Docs follow-up: nextlevelbuilder/dewee-web-v2#134 already tracks the service-binding feature; no additional public configuration change in this fix.