Normalize edamame opts - #822
Merged
Merged
Conversation
Collaborator
Author
|
Oops, I accidentally clicked on "Request review" when Copilot was selected, my bad. |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
Updates Edamame parsing by normalizing options before reading ClojureScript namespace declarations.
Changes:
- Normalize options before calling
parse-next. - Upgrade Edamame to
1.6.44.
File summaries
| File | Description |
|---|---|
src/nextjournal/clerk/cljs_libs.clj |
Normalizes Edamame options for CLJS namespace parsing. |
deps.edn |
Updates the Edamame dependency. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mk Can you please merge this? edamame will start throwing in
parse-nextwhen options aren't normalized first. This is for perf and correctness reasons.