Open
Conversation
This comment has been minimized.
This comment has been minimized.
Member
violoncelloCH
left a comment
violoncelloCH
left a comment
There was a problem hiding this comment.
hi, thanks for your PR!
though I'm not sure if I understand it correctly: see my comments in the review...
| if ($this->sslmode === 'tls') { | ||
| curl_setopt($ch, CURLOPT_USE_SSL, CURLUSESSL_ALL); | ||
|
|
||
| if ($this->sslmode !== 'tls') { |
Member
There was a problem hiding this comment.
shouldn't people with tls set use STARTTLS by default? - this would exclude them, right?
| curl_setopt($ch, CURLOPT_USE_SSL, CURLUSESSL_ALL); | ||
| } | ||
| } else { | ||
| $protocol = 'imaps'; |
Member
There was a problem hiding this comment.
you set the $protocol two times to imaps but for starttls (and insecure connections) we would need imap, right?
| $protocol = ($this->sslmode === "ssl") ? "imaps" : "imap"; | ||
| $url = "{$protocol}://{$this->mailbox}:{$this->port}"; | ||
| $ch = curl_init(); | ||
| if ($this->sslmode === 'tls') { |
Member
There was a problem hiding this comment.
maybe a simpler solution: how about just changing this line to include everything expect:
- explicit
ssl(and also TRUE), - explicit
nossl,notls, maybe "empty string" (and also FALSE)
so everything else (includingtls) would be handled as STARTTLS...
what do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quickly looked at the new code and noted that setting
sslmodeto something liketruedisables encryption, if I'm right? This PR is not tested at all, but I don't wanted to sketch what might be a better solution.