fix(social): stop follow-nextcloud button overlapping welcome banner - #2152
Closed
jospoortvliet wants to merge 1 commit into
Closed
jospoortvliet wants to merge 1 commit into
jospoortvliet wants to merge 1 commit into
Conversation
The button relied on float:inline-end with nothing clearing the float, collapsing .follow-nextcloud's height and letting the button overlap neighboring content. Use flexbox instead. Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Jos Poortvliet <jospoortvliet@gmail.com>
Member
|
thanks for the PR. The complete interface was replaced in the meantime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Follow Nextcloud on mastodon.xyz" button in the welcome banner overlaps surrounding text (see screenshot below). The button used
float: inline-endinside.follow-nextcloud, but nothing cleared the float, so the container's height collapsed and the button overlapped neighboring content instead of sitting below the paragraph.Fix: use flexbox (
display: flex; flex-direction: column; align-items: flex-end) instead of float, so the button lays out in normal flow, right-aligned below the paragraph.AI disclosure
This change (root-cause analysis and the CSS fix) were drafted with Claude Code and reviewed by me before submission, per the Nextcloud AI Contribution Policy.
Test plan
firstrunflag) so the welcome banner shows