Conversation
Signed-off-by: Louis Chmn <louis@chmn.me>
artonge
requested review from
CarlSchwan and
icewind1991
and removed request for
a team
September 20, 2026 13:56
come-nc
requested changes
Sep 20, 2026
come-nc
left a comment
come-nc
left a comment
Contributor
There was a problem hiding this comment.
Not needed in the end, the current code makes sense.
Explanation:
- For basic auth with password, we wait until we are sure the client supports cookies (by setting a test cookie and reading it back on the next request) before we create a session in DB and consider the PHP session as a valid one.
- For basic auth with an app-password, we already have a DB line we can use for the session, the one of the app-password, so we directly mark the session as valid and link it to the app password, no need for test cookie.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.