Conversation
Since object-ids is filtered by user visibility, clients writing the list back omit files the user cannot see, which were then treated as removed and rejected with a 403. Only visible files are now added or removed. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
requested review from
CarlSchwan,
come-nc,
icewind1991 and
leftybournes
and removed request for
a team
September 16, 2026 20:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64281
Since #63946, the
object-idsPROPFIND only lists files the user can see, but the PROPPATCH still compared the submitted list against every tagged file. The tag picker writes back what it read, so any tagged file the user can't see (another user's file, a file in the trash) counted as a removal and got a 403. Tagging and untagging from the picker broke as soon as a tag was on such a file, for admins as well.A
setorremoveofobject-idsnow only adds or removes files the user can see; files hidden from the user keep the tag. Adding a hidden file, or changing a visible file without update permission, is still forbidden.#63946 was backported to stable31 to stable35 (shipped in 32.0.15, 33.0.9 and 34.0.4), so this needs the same backports.