fix(theming): read image keys from Mime-suffixed key in theming:config - #64381
Open
shawon9324 wants to merge 10 commits into
Open
shawon9324 wants to merge 10 commits into
shawon9324 wants to merge 10 commits into
Conversation
…ng:config occ theming:config <key> always reported image keys (background, logo, logoheader, favicon) as "currently not set", even when a value was configured and served correctly by the web UI. Image values are stored under "<key>Mime" in the theming app config, a convention already used by this command's list-all branch and by the value-writing branch further down. The single-key read branch was the only one still reading the plain key, so it never found the stored value. Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Md. Shahriar Karim Shawon <shawon9324@gmail.com>
shawon9324
requested review from
CarlSchwan,
come-nc,
leftybournes and
salmart-dev
and
a lite review from Copilot
and removed request for
a team
September 15, 2026 18:26
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Fixes occ theming:config <imageKey> so single-key reads use the MIME-suffixed config key (e.g., logoMime) consistently with the image write path and the list-all branch.
Changes:
- Update
UpdateConfigto read image keys from<key>Mimeinstead of<key>. - Add PHPUnit coverage for regular key reads and image key MIME-suffixed reads.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/theming/lib/Command/UpdateConfig.php | Fixes the config lookup for image keys by using the MIME-suffixed storage key. |
| apps/theming/tests/Command/UpdateConfigTest.php | Adds unit tests validating the corrected lookup behavior for regular and image keys. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Running
occ theming:config logoreported that the logo was not set, eventhough
theming.logoMimewas correctly set toimage/png. The single-keyimage read path was the only branch using the wrong storage key; the list-all
image branch and the image write path already correctly appended the
Mimesuffix. This change updates that lookup to use the correct image MIME
configuration key.
Verified on a local instance with
theming.logoMimeset toimage/png:Checklist
AI (if applicable)