Skip to content

feat: Throw an error when trying to listen to no longer used signals - #64363

Draft
come-nc wants to merge 10 commits into
masterfrom
come/allow-list-hooks
Draft

come-nc wants to merge 10 commits into
masterfrom
come/allow-list-hooks

Conversation

@come-nc

@come-nc come-nc commented Sep 15, 2026

Copy link
Copy Markdown
Contributor
  • Resolves: #

Summary

Same as #59489 but rebased on master.
I pushed as a new PR because there was a lot of conflicts, wanted to make sure I did not miss anything.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@come-nc come-nc added this to the Nextcloud 36 milestone Sep 15, 2026
@come-nc come-nc self-assigned this Sep 15, 2026
@come-nc come-nc added the 2. developing Work in progress label Sep 15, 2026
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@come-nc
come-nc force-pushed the come/allow-list-hooks branch 3 times, most recently from 00a2549 to 0a2f332 Compare September 17, 2026 09:49
CarlSchwan and others added 8 commits September 17, 2026 14:14
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Allow to use ::class as class names. Only works if the class actually
exists, which in many case, isn't the case anymore.

Signed-off-by: Carl Schwan <carlschwan@kde.org>
And replace the few remaining by converting the event to hooks instead
of the other way around.

Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Allow to get rid of more legacy code and make sure UserSessionTest is
also in psalm

Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
come-nc force-pushed the come/allow-list-hooks branch from 50f1f1d to ec35b78 Compare September 17, 2026 12:14
Registering listeners was messing with other tests, use a mocked event
 dispatcher instead. Also fixed a few constructor calls.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants