fix(files_external): align filesystem change detection defaults - #64333
Open
joshtrichards wants to merge 5 commits into
Open
joshtrichards wants to merge 5 commits into
joshtrichards wants to merge 5 commits into
Conversation
Apply the OncePerRequest filesystem-check policy when an external mount does not define filesystem_check_changes. This keeps mounts created through occ and imports consistent with GUI-created mounts while preserving explicitly configured values. Fixes #53249 Signed-off-by: Josh <josh.t.richards@gmail.com>
Verify that mounts without an explicit filesystem_check_changes option default to checking once per request, while preserving explicit values for Never, OncePerRequest, and Always. Also cover loading legacy mounts that lack the option. Assisted-by: Copilot:gpt-5.6-luna Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
bug
2. developing
joshtrichards
requested review from
Altahrim and
leftybournes
and removed request for
a team
September 14, 2026 21:35
joshtrichards
added
3. to review
CarlSchwan
approved these changes
Sep 15, 2026
Accept native mount-option values in DBConfigService and add round-trip coverage for numeric and boolean options. Also skip the inherited filesystem-check test for UserGlobalStoragesService, which is read-only. Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
occ files_external:createdoes not detect remote file changes #53249Summary
The web interface initializes new external storage mounts with
filesystem_check_changes = 1, butfiles_external:create,files_external:import, and other non-GUI creation paths could omit the option.When the option was absent, the runtime fell back to the global
filesystem_check_changessetting, whose default is0(Never). As a result, files added to or removed from the underlying storage could remain invisible until a manualocc files:scanor another operation refreshed the file cache.This change ensures external storage mounts consistently use
filesystem_check_changes = 1(Once every direct access) when no mount-specific value is configured.Changes:
1when loading existing external storage mounts withoutfilesystem_check_changes.StoragesService::addStorage().0— Never1— Once every direct access2— AlwaysThe global
filesystem_check_changessetting is unchanged, and existing explicit mount settings are preserved.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)