Refactor: Centralize logic for checking if a share is password protected#61946
Open
theCalcaholic wants to merge 1 commit into
Open
Refactor: Centralize logic for checking if a share is password protected#61946theCalcaholic wants to merge 1 commit into
theCalcaholic wants to merge 1 commit into
Conversation
theCalcaholic
requested review from
come-nc,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
18 tasks
Author
|
@miaulalala This is the refactoring portion we were talking about. |
theCalcaholic
force-pushed
the
feature/refactor-share-is-pw-protected
branch
from
cc7b47c to
f019b17
Compare
…rd protected in IShare->isPasswordProtected()
theCalcaholic
force-pushed
the
feature/refactor-share-is-pw-protected
branch
from
f019b17 to
85cac33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, there were numerous checks that check whether a share has an empty or null password scattered around the code base. This PR moves the logic for this into a single, central method on IShare.
This PR prepares and is a prerequisite for #61722.
Checklist
3. to review, feature component)stable32)AI (if applicable)