Repository navigation
feat: show each file's folder in the Office overview - #220
Open
thiagoneritorqueti wants to merge 1 commit into
Open
thiagoneritorqueti wants to merge 1 commit into
thiagoneritorqueti wants to merge 1 commit into
Conversation
The "Recent" grid and list render only the file name and its modification date, so two files with the same name in different folders — a common case for anything named "Budget" or "Report" — look identical and the user has to open each one to tell them apart. Append the file's folder to the date in both views: "January 2024 · /Projects/2024", or "/" for a file at the root. The folder comes from the Node's dirname, which the search already returns; nothing new is fetched. The makeNode fixture gains an optional dirname so a spec can place a file in a subfolder; it defaults to the root, so existing callers are unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MhzEzra157kFTkV9ukxmRa Signed-off-by: Thiago Neri Torqueti <thiago.torqueti@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the Office overview, "Recent" shows only the file name and the modification date. Two files with the same name in different folders (every supermarket has a dozen
Pedido.xlsx) look identical, and the only way to tell them apart is to open each one.This appends the file's folder to the date, in both the grid and the list view:
A file at the root shows
/.How
OfficeOverview.vue: a smallfolderLabel(file)helper readsNode.dirname(already in the search result — nothing new is fetched) and both#subnameslots render it afterNcDateTime.fixtures.ts:makeNodegains an optionaldirname(defaults to the root, so existing callers are unchanged).OfficeOverview.spec.ts: two cases, grid and list, pinning that the folder is rendered and that a root file shows/.Reuse before you write
Option 4 (existing pattern in
src/): the folder is read from the@nextcloud/filesNodethe overview already holds, and rendered through the existing#subnameslot next toNcDateTime. No new component or dependency.Notes for review
js/andcss/are not included —/compileis still needed.·-separated last-folder-only form if the full path is too long for the card.🤖 Generated with Claude Code
https://claude.ai/code/session_01MhzEzra157kFTkV9ukxmRa